Ci/docker compose pyyaml cython -- unit mock assertions #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
CI is failing recently on local integration testing due to some dependency issues.
docker-compose
depends onpyyaml<6
whose installation is broken with the newly releasedcython==3
.Until someone fixes things in a way that doesn't require a workaround, we're putting a workaround in place.
Also took this opportunity to remove
six
and a constraint for py2.7 since we don't support it anymore.Another error has been revealed: we had several instances of
assert some_mock.called_once_with(...)
which is a classic error; the method name isassert_called_once_with
and since the mock returns aMagicMock
for all members that don't exist, the incorrect form always assertsTrue
.It seems that in python 3.12 this case has been caught as a probable error, and our CI is failing on these:
ISSUE TYPE