Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vault_write lookup and module #223

Merged
merged 28 commits into from
Mar 26, 2022

Conversation

briantist
Copy link
Collaborator

SUMMARY

Resolves #174

Adds generic vault_write lookup and module to support generic writes; the counterparts to the vault_read lookup and module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vault_write

ADDITIONAL INFORMATION

@briantist briantist added the enhancement New feature or request label Mar 2, 2022
@briantist briantist added this to the v2.4.0 milestone Mar 2, 2022
@briantist briantist self-assigned this Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #223 (810863e) into main (9604e74) will increase coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   97.14%   97.49%   +0.35%     
==========================================
  Files          51       56       +5     
  Lines        2206     2518     +312     
  Branches      168      185      +17     
==========================================
+ Hits         2143     2455     +312     
  Misses         49       49              
  Partials       14       14              
Flag Coverage Δ
env_docker-default 97.49% <100.00%> (+0.35%) ⬆️
integration 80.55% <75.92%> (-0.53%) ⬇️
sanity 38.61% <40.74%> (+0.24%) ⬆️
target_ansible-doc 100.00% <100.00%> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 75.51% <98.71%> (+2.22%) ⬆️
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 38.61% <40.74%> (+0.24%) ⬆️
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_login 100.00% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 82.97% <ø> (ø)
target_lookup_vault_write 59.14% <78.18%> (?)
target_module_utils 95.90% <50.00%> (-0.82%) ⬇️
target_module_vault_login 93.93% <ø> (ø)
target_module_vault_pki_generate_certificate 78.26% <ø> (ø)
target_module_vault_read 92.10% <ø> (ø)
target_module_vault_token_create 90.00% <ø> (ø)
target_module_vault_write 57.53% <73.58%> (?)
target_modules 70.19% <96.11%> (+6.03%) ⬆️
units 93.50% <98.07%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/wrapping.py 100.00% <100.00%> (ø)
plugins/lookup/vault_write.py 100.00% <100.00%> (ø)
plugins/modules/vault_write.py 100.00% <100.00%> (ø)
tests/unit/conftest.py 92.15% <100.00%> (+6.97%) ⬆️
tests/unit/plugins/lookup/test_vault_write.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_vault_write.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9604e74...810863e. Read the comment docs.

@briantist briantist force-pushed the content/vault_write branch from 47f166a to 11cf3a5 Compare March 6, 2022 18:41
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://community-hashi-vault-main.surge.sh

@briantist briantist marked this pull request as ready for review March 13, 2022 19:07
Copy link

@lowlydba lowlydba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! No comments 😶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support writing to Vault
2 participants