Fix various sanity errors in plugins #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
become
There was a problem hiding this comment.
@felixfontein feel free to ignore all cosmetic suggestion.. When i started i didn't see that there is a total mess with formatting, etc.
|
Indeed, there's a huge mess in the plugin docs as well :) I've still commited your suggestions so at least they get fixed. |
|
@Andersson007 thanks a lot for reviewing this! |
patchback bot
pushed a commit
that referenced
this pull request
Sep 16, 2020
* Fix deprecation of callables. * Fix various sanity errors. * Revert callback_type -> type transform. * Fix stat_result times: these are float according to https://github.com/python/typeshed/blob/master/stdlib/3/os/__init__.pyi * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 7cf4728)
felixfontein
added a commit
that referenced
this pull request
Sep 17, 2020
* Fix deprecation of callables. * Fix various sanity errors. * Revert callback_type -> type transform. * Fix stat_result times: these are float according to https://github.com/python/typeshed/blob/master/stdlib/3/os/__init__.pyi * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 7cf4728) Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix some errors found with ansible/ansible#71734.
ISSUE TYPE
COMPONENT NAME
plugins/become/pfexec.py
plugins/callback/cgroup_memory_recap.py
plugins/callback/counter_enabled.py
plugins/callback/diy.py
plugins/callback/hipchat.py
plugins/callback/logdna.py
plugins/callback/mail.py
plugins/callback/null.py
plugins/callback/selective.py
plugins/callback/slack.py
plugins/callback/stderr.py
plugins/callback/syslog_json.py
plugins/inventory/gitlab_runners.py
plugins/lookup/chef_databag.py
plugins/lookup/consul_kv.py
plugins/lookup/credstash.py
plugins/lookup/cyberarkpassword.py
plugins/lookup/dig.py
plugins/lookup/dsv.py
plugins/lookup/etcd3.py
plugins/lookup/filetree.py
plugins/lookup/gcp_storage_file.py
plugins/lookup/hashi_vault.py
plugins/lookup/hiera.py
plugins/lookup/keyring.py
plugins/lookup/lastpass.py
plugins/lookup/lmdb_kv.py
plugins/lookup/nios.py
plugins/lookup/nios_next_ip.py
plugins/lookup/nios_next_network.py
plugins/lookup/onepassword.py
plugins/lookup/onepassword_raw.py
plugins/lookup/passwordstore.py
plugins/lookup/redis.py
plugins/lookup/shelvefile.py
plugins/lookup/tss.py