Add docker build output to task result #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
cloud
community_review
docker
feature
|
You need a changelog fragment. Will look at the change itself later... |
martinm82
reviewed
Sep 29, 2020
|
@raags could you please update your PR? needs_info |
Andersson007
added
the
needs_info
ansibullbot
added
integration
tests/integration/targets/docker_image/tasks/tests/docker_image.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/docker_image/tasks/tests/docker_image.yml
Outdated
Show resolved
Hide resolved
The build output is only added during failures, but its useful to have this available during normal task execution as well.
felixfontein
removed
the
needs_info
patchback bot
pushed a commit
that referenced
this pull request
Nov 15, 2020
The build output is only added during failures, but its useful to have this available during normal task execution as well. (cherry picked from commit 33b8d1c)
|
@raags thanks a lot for contributing this! |
felixfontein
pushed a commit
that referenced
this pull request
Nov 15, 2020
The build output is only added during failures, but its useful to have this available during normal task execution as well. (cherry picked from commit 33b8d1c) Co-authored-by: Raghu Siddarth Udiyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The build output is only added during failures, but its useful to have this available during normal task execution as well.
ISSUE TYPE
COMPONENT NAME
docker_image
ADDITIONAL INFORMATION
This change adds a new key
build_outputto the task result which includes all the docker build steps. This is useful to understand for e.g. what steps were run for the build, as well as steps that used / not used the image cache.