-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SetSessionService to redfish_config #5009
Add SetSessionService to redfish_config #5009
Conversation
adding SetSessionService command to redfish_config to set BMC default session timeout policy. Fixes ansible-collections#5008
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you take a look at @mraineri's suggestion as well (https://github.com/ansible-collections/community.general/pull/5009/files#r930114637)? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tejabailey thanks for your contribution!
I left a couple of comments.
- changed category from SessionService to Sessions - changed set_sessionservice() to set_session_service() - other misc. changes for cleanup
This comment was marked as outdated.
This comment was marked as outdated.
@felixfontein I missed the discussion about this Docs Build feature in the PRs. Why do they get so long? It is quite annoying to work in the PR having to scroll multiple pages in the browser up and down. |
@felixfontein working on it, thank you. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi! I The last pylint error has been corrected. Is this PR ok to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change request, then we can merge (assuming that @mraineri does not have further comments).
I do not have anything else; everything looks good to me so far. |
Co-authored-by: Felix Fontein <[email protected]>
(The REUSE fail is because the test was changed to not rebase. That way I don't have to manually approve every run :) At least for this PR it can be safely ignored.) |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5311 🤖 @patchback |
* Add SetSessionService to redfish_config adding SetSessionService command to redfish_config to set BMC default session timeout policy. Fixes #5008 * fix white space issues * Making Requested changes: - changed category from SessionService to Sessions - changed set_sessionservice() to set_session_service() - other misc. changes for cleanup * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> * Fix issues with checks * Fix issues with checks part 2 * Fix issues with checks part 3 * Update plugins/modules/remote_management/redfish/redfish_config.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit d9d830a)
@tejabailey thanks for this contribution! |
* Add SetSessionService to redfish_config adding SetSessionService command to redfish_config to set BMC default session timeout policy. Fixes #5008 * fix white space issues * Making Requested changes: - changed category from SessionService to Sessions - changed set_sessionservice() to set_session_service() - other misc. changes for cleanup * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> * Fix issues with checks * Fix issues with checks part 2 * Fix issues with checks part 3 * Update plugins/modules/remote_management/redfish/redfish_config.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit d9d830a) Co-authored-by: tejabailey <[email protected]>
* upstream/main: (203 commits) Make pfexec become usable for illumos (ansible-collections#3889) znode: add options for authentication (ansible-collections#5306) keycloak_user_federation: add explanation and example to vendor option (ansible-collections#4893) Next expected release is 5.8.0. Allow terraform module to specify complex variable structures (ansible-collections#4797) Fix ansible-collections#5313: redhat_subscription module is not idempotent when pool_ids (ansible-collections#5319) bitwarden: Add field to search for all item attributes, instead of on… (ansible-collections#5297) New Module: Keycloak User Rolemapping (ansible-collections#4898) chore: Update lxc_container to support py3 (ansible-collections#5304) terraform: run `init` with no-color, too (ansible-collections#5147) nmcli: fix error when setting previously unset mac address (ansible-collections#5291) [feat] proxmox_snap: snapshot containers with configured mountpoints (ansible-collections#5274) machinectl: include the success command (ansible-collections#5287) Add SetSessionService to redfish_config (ansible-collections#5009) locale_gen: fix UbuntuMode (ansible-collections#5282) ini_file: fix lint error (ansible-collections#5307) netcup_dnsapi: Add timeout paramter (ansible-collections#5301) stable-2.14 is now default. Add stable-2.14 to CI, adjust to devel version bump (ansible-collections#5298) Try to run reuse workflow without explicitly allowing it for new contributors. (ansible-collections#5296) ...
* Add SetSessionService to redfish_config adding SetSessionService command to redfish_config to set BMC default session timeout policy. Fixes ansible-collections#5008 * fix white space issues * Making Requested changes: - changed category from SessionService to Sessions - changed set_sessionservice() to set_session_service() - other misc. changes for cleanup * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> * Fix issues with checks * Fix issues with checks part 2 * Fix issues with checks part 3 * Update plugins/modules/remote_management/redfish/redfish_config.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
* Add SetSessionService to redfish_config adding SetSessionService command to redfish_config to set BMC default session timeout policy. Fixes ansible-collections#5008 * fix white space issues * Making Requested changes: - changed category from SessionService to Sessions - changed set_sessionservice() to set_session_service() - other misc. changes for cleanup * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> * Fix issues with checks * Fix issues with checks part 2 * Fix issues with checks part 3 * Update plugins/modules/remote_management/redfish/redfish_config.py Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
adding SetSessionService command to redfish_config
to set BMC default session timeout policy.
Fixes #5008
ISSUE TYPE
COMPONENT NAME
redfish_config