Module listen ports facts extend output

[PKehnel]

SUMMARY

Include more infos from netstat or ss to the output.

Mainly:

• state
• foreign address
• process

As raised in #4762

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

listen_portcs_facts

ADDITIONAL INFORMATION

Changes:

• adding the parameter: '-a', to netstat and ss to include all connections.
• rework netstat to a more general solution.

Open topics:

• first time trying to contribute to a public repo, even so the pull request is not 100% done I wanted to get some initial feedback.

• is the approach I took okay or should we maybe add a parameter to listen_ports_facts to contain more information, while keeping the format of the current solution as standard.

• docstring type, is there a convention for this repo, I didn't find that info

• Should I rework ss to have the same setup then network

• Testing:

  • What is the verbatim output I should add?
  • How to test SS, I would need to change docker version to for example a redhat 7 machine, but ansible-test integration listen_ports_facts --docker centos7 -v fails for me with Gather Factes -> unreachable
  • Testing Netstat: ansible-test integration listen_ports_facts --docker -v uses netstat is working successful
    with the warning: WARNING: Unable to determine context for the following test targets, they will be run on the target host: listen_ports_facts

• how to run pre-commit hook for my changes?
  community/general/plugins/modules/system/listen_ports_facts.py

• what is the verbatim output?

@gaetan-craft maybe you give me some initial feedback?

[ansibullbot]

cc @ndavison
click here for bot help

[PKehnel]

@moonrail and @gaetan-craft could one of you give me an initial review and some feedback on my idea / thoughts.

• is the approach I took okay or should we maybe add a parameter to listen_ports_facts to contain all information, while keeping the basic format of the current solution as standard. ( I prefer that solution actually)

• What is the verbatim output I should add?

• Also will try to add some more documentation

[PKehnel]

ready_for_review

[felixfontein]

Just some generic comments :) (Also still needs a changelog fragment.)

[github-actions]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[felixfontein]

You probably want to update the return value documentation (RETURN) to mention the new fields.

[ansibullbot]

@PKehnel this PR contains the following merge commits:

• 305de35

Please rebase your branch to remove these commits.

click here for bot help