Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4377/dbad1e0f backport][stable-4] Allow Proxmox Snapshot Restoring #4571

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 25, 2022

This is a backport of PR #4377 as merged into main (dbad1e0).

SUMMARY

Allows the restoration of a proxmox snapshot
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

This Change allows restoring a snapshot in Proxmox
ADDITIONAL INFORMATION

This is the result of #4375
I did not mark snapname as required, as it has a default value and the behaviour didn't change. Or should i still mark it as required?

* Allow restoring of snapshots

* Fix formatting

* Add documentation for new feature

* Revert unrelated reformatting

* Add documentation for snapshot change

* Remove redundant multiple call to status API

* Remove unneccesary indent

* Add documentation for timeout fix

* Update changelog fragment to reflect real changes

Co-authored-by: Felix Fontein <[email protected]>

* Update changelog fragment to reflect real changes

Co-authored-by: Felix Fontein <[email protected]>

* Add Tests for Snapshot rollback

* Update tests/unit/plugins/modules/cloud/misc/test_proxmox_snap.py

Co-authored-by: Felix Fontein <[email protected]>

* Update changelogs/fragments/4377-allow-proxmox-snapshot-restoring.yml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/cloud/misc/proxmox_snap.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit dbad1e0)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport cloud feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit labels Apr 25, 2022
@felixfontein felixfontein merged commit 868a630 into stable-4 Apr 25, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/dbad1e0f1123cbb8694fa6571770176c394fe711/pr-4377 branch April 25, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants