Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing '>'. #4080

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Fix missing '>'. #4080

merged 1 commit into from
Jan 25, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Noticed while working on ansible-community/antsibull-build#389.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

manageiq_alerts

@ansibullbot
Copy link
Collaborator

cc @abellotti @cben @dkorn @elad661 @evertmulder @gtanzillo @yaacov @zgalor
click here for bot help

@ansibullbot ansibullbot added docs docs_only module module plugins plugin (any type) remote_management small_patch Hopefully easy to review labels Jan 25, 2022
@felixfontein felixfontein merged commit 5fead8b into ansible-collections:main Jan 25, 2022
@patchback
Copy link

patchback bot commented Jan 25, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/5fead8bbde52586ed9f6c4ef8ebca1e489b6a44b/pr-4080

Backported as #4081

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the fix-docs branch January 25, 2022 06:50
patchback bot pushed a commit that referenced this pull request Jan 25, 2022
@felixfontein @patchback
Fix missing '>'. (#4080)
94ad13f 
(cherry picked from commit 5fead8b)
@patchback patchback bot mentioned this pull request Jan 25, 2022
Merged
@patchback
Copy link

patchback bot commented Jan 25, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/5fead8bbde52586ed9f6c4ef8ebca1e489b6a44b/pr-4080

Backported as #4082

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 25, 2022
@felixfontein @patchback
Fix missing '>'. (#4080)
7675e09 
(cherry picked from commit 5fead8b)
@patchback patchback bot mentioned this pull request Jan 25, 2022
Merged
felixfontein added a commit that referenced this pull request Jan 25, 2022
@patchback @felixfontein
Fix missing '>'. (#4080) (#4082)
499f4b4 
(cherry picked from commit 5fead8b)

Co-authored-by: Felix Fontein <[email protected]>
felixfontein added a commit that referenced this pull request Jan 25, 2022
@patchback @felixfontein
Fix missing '>'. (#4080) (#4081)
e600fe5 
(cherry picked from commit 5fead8b)

Co-authored-by: Felix Fontein <[email protected]>
@gundalow
Copy link
Contributor

How did you find this?
I'm concerned there could be other instances. Did validate-modules need updating?

@felixfontein
Copy link
Collaborator Author

@gundalow I was looking at the diff of the generated RST files between two different iterations of ansible-community/antsibull-build#389 and noticed a strange change (it changed from empty replacement to <). When I checked the original string, I saw it had a < without a matching >.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs_only docs module module plugins plugin (any type) remote_management small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @gundalow