mysql_info: Add parameter for __collect method #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameter for `__collect` method By default the class `MySQL_Info` get all MySQL instance information, add parameter for `__collect` to get only what wants to know(information) Feature Pull Request lib/ansible/modules/database/mysql/mysql_info.py
ansibullbot
added
backport
feature
Andersson007
approved these changes
Apr 10, 2020
|
@lyvivian0077 let's wait a bit, maybe anybody else will want to review it. |
|
Sensible optimisation to me, big fan of pulling only what's needed. shipit |
|
oh, @lyvivian0077 we need a changelog fragment https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs. |
- bugfixes: - mysql_info - add parameter for __collect to get only what are wanted (ansible-collections#136).
|
@Andersson007 |
|
@lyvivian0077 merged, thanks for the PR! |
|
@Xyon thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add parameter for
__collectmethodBy default the class
MySQL_Infoget all MySQL instance information,add parameter for
__collectto get only what wants to know(information)ISSUE TYPE
Feature Pull Request
COMPONENT NAME
lib/ansible/modules/database/mysql/mysql_info.py