fix so module nios_host_record can remove aliases (#1470)

* fix for #1335 * added changelog fragment * Update changelogs/fragments/nios_host_record-fix-aliases-removal.yml Co-authored-by: Felix Fontein <[email protected]> * extend changelog to specify CNAMES Co-authored-by: Felix Fontein <[email protected]>
ansible-collections · Dec 14, 2020 · 496be77 · 496be77
1 parent f37eb12
commit 496be77
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/changelogs/fragments/nios_host_record-fix-aliases-removal.yml b/changelogs/fragments/nios_host_record-fix-aliases-removal.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - nios_host_record - fix to remove ``aliases`` (CNAMES) for configuration comparison (https://github.com/ansible-collections/community.general/issues/1335).
diff --git a/plugins/module_utils/net_tools/nios/api.py b/plugins/module_utils/net_tools/nios/api.py
@@ -455,6 +455,9 @@ def compare_objects(self, current_object, proposed_object):
                 return False
 
             elif isinstance(proposed_item, list):
+                if key == 'aliases':
+                    if set(current_item) != set(proposed_item):
+                        return False
                 for subitem in proposed_item:
                     if not self.issubset(subitem, current_item):
                         return False