-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker_container_copy_into module #545
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two suggestions (that could be done in other PRs):
A content
option (a la copy
module) for writing small-ish content directly without having an actual source file.
A base64_content
(name could be changed) that does similar to content
but you supply it base64 pre-encoded content, which is decoded on the target.
Co-authored-by: Brian Scholer <[email protected]>
Things left to implement:
|
…n does not exist.
Ok, I think this is ready for review again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of my inline questions/comments are blocking, this is great stuff!
content_is_b64=dict(type='bool', default=False), | ||
|
||
# Undocumented parameters for use by the action plugin | ||
_max_file_size_for_diff=dict(type='int'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be exposed as a documented/configurable option for the module, which defaults to the Ansible configuration value if not otherwise set? Or do you think it's better not to let this be set independently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think for now I'd like to keep it this way. It can still be renamed / documented at any point.
Co-authored-by: Brian Scholer <[email protected]>
@briantist thanks a lot for reviewing this! |
SUMMARY
Create a module to copy files into a container.
ISSUE TYPE
COMPONENT NAME
docker_container_copy_into