For Python > 2, always use shutil.which instead of custom Windows helper code #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per code. This is related to docker/docker-py@4278981 in the sense that for Python > 2, we also exclusively use shutil.which now, but we do not remove the helper function since we need it for Python 2 on Windows. Co-authored-by: Daniel Möller <[email protected]>
briantist
approved these changes
Aug 8, 2022
|
CI failure is consistent, but unrelated to this PR. I'll merge this and investigate separately. |
|
@briantist thanks a lot for reviewing this! |
This was referenced Aug 12, 2022
ghost
mentioned this pull request
1 task
1 task
This was referenced Aug 12, 2022
1 task
1 task
This was referenced Sep 25, 2022
1 task
This was referenced Oct 20, 2022
This was referenced Oct 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is related to docker/docker-py@4278981 in the sense that for Python > 2, we also exclusively use shutil.which now, but we do not remove the helper function since we need it for Python 2 on Windows.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/_api/credentials/utils.py