Improve/fix API version handling #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added a commit
to felixfontein/community.docker
that referenced
this pull request
Jun 18, 2022
felixfontein
changed the title
briantist
approved these changes
Jun 20, 2022
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #391 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
(cherry picked from commit a44e073)
|
@briantist thanks for reviewing this! |
felixfontein
added a commit
that referenced
this pull request
Jun 20, 2022
(cherry picked from commit a44e073) Co-authored-by: Felix Fontein <[email protected]>
This was referenced Jul 2, 2022
Closed
Merged
1 task
This was referenced Jul 2, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Right now we retrieve the API version (the latest one supported by the daemon!) from the Docker daemon after creating the Docker SDK for Python API client. If the
versionmodule/plugin parameter is used, we should use that version instead, and if it is not used, the Python API client already retrieved that version for us. So let's safe one API call and use the API version supplied by the Python API client.(The property exists since Docker SDK for Python 1.5.0: docker/docker-py@7a6980d We require version 1.8.0 or newer, so we can depend on it.)
ISSUE TYPE
COMPONENT NAME
Docker SDK for Python based plugins and modules