Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WILL BE SPLIT UP] Start adjusting some modules #387

Closed
wants to merge 14 commits into from

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Jun 18, 2022

SUMMARY

Modules I want to adjust:

  • docker_container_exec
  • docker_container_info
  • docker_container
  • docker_host_info
  • docker_image_info
  • docker_image_load
  • docker_image
  • docker_login
  • docker_network_info
  • docker_network
  • docker_prune
  • docker_volume_info
  • docker_volume

The idea is to support Python 2.7+. Maybe it also works with 2.6, but I don't know.

Ref: #364

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

various

@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST wait for the next major release label Jun 18, 2022
@github-actions
Copy link

github-actions bot commented Jun 18, 2022

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

@felixfontein felixfontein force-pushed the docker-py branch 2 times, most recently from 5ae47e3 to 5936e41 Compare June 18, 2022 12:50
@felixfontein
Copy link
Collaborator Author

The idea is not that this PR should convert all modules and plugins, but start with a few to see which helper APIs should be provided by APIClient and by AnsibleDockerClientBase.

@felixfontein felixfontein force-pushed the docker-py branch 14 times, most recently from 33a5d32 to 91fa719 Compare June 24, 2022 06:55
@felixfontein felixfontein changed the title [WIP] Vendor API connection code from Docker SDK for Python, start adjusting some modules Vendor API connection code from Docker SDK for Python, start adjusting some modules Jun 25, 2022
@felixfontein
Copy link
Collaborator Author

docker_container is a lot harder to convert, so I'll work on that in a follow-up PR. I have been long thinking about a general rework of that module anyway, maybe I'll combine that with adjusting the module to use the vendored code.

@felixfontein
Copy link
Collaborator Author

I will probably split this up into one general PR (for the common module utils), and then once that's merged, one PR per module and plugin, so that it will be easier to review.

@felixfontein
Copy link
Collaborator Author

The module_utils and plugin_utils part is in #398.

@felixfontein felixfontein changed the title Vendor API connection code from Docker SDK for Python, start adjusting some modules [WILL BE SPLIT UP] Vendor API connection code from Docker SDK for Python, start adjusting some modules Jun 30, 2022
@felixfontein felixfontein changed the title [WILL BE SPLIT UP] Vendor API connection code from Docker SDK for Python, start adjusting some modules [WILL BE SPLIT UP] Start adjusting some modules Jul 2, 2022
@felixfontein
Copy link
Collaborator Author

I've rebased now that the separate vendoring PR has been merged.

@felixfontein
Copy link
Collaborator Author

I created the following PRs for the parts of this PR:

@felixfontein felixfontein deleted the docker-py branch July 2, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change This PR contains a breaking change that MUST wait for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant