Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker connection plugin: fix config docs and update to use config system #297

Merged
merged 25 commits into from
Mar 21, 2022
Merged

docker connection plugin: fix config docs and update to use config system #297

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4cea44c
fix config docs and update to use config system
bcoca Feb 10, 2022
9a63b3f
moar fixes
bcoca Feb 10, 2022
a403292
Update plugins/connection/docker.py
bcoca Feb 11, 2022
e8916c2
updated for backwards compat
bcoca Feb 11, 2022
715ace2
badmergeresolution
bcoca Feb 11, 2022
de4a79b
makeitworks
bcoca Feb 11, 2022
37717fa
attempt to fix unit test
bcoca Feb 11, 2022
af610f3
mocking it# No more than 50 chars. #### 50 chars is here: #
bcoca Feb 11, 2022
116ae60
Update plugins/connection/docker.py
bcoca Feb 14, 2022
a53a975
Update plugins/connection/docker.py
bcoca Feb 14, 2022
f51504f
Update plugins/connection/docker.py
bcoca Feb 14, 2022
b70cff2
Update plugins/connection/docker.py
bcoca Feb 14, 2022
d927149
Update plugins/connection/docker.py
bcoca Feb 14, 2022
4eb3684
Update plugins/connection/docker.py
bcoca Feb 14, 2022
c56483b
nomock
bcoca Feb 14, 2022
58a659b
remove bad paste
bcoca Feb 14, 2022
9905b40
properly load connection to initialize config
bcoca Feb 14, 2022
6e64d39
initizlie docker args
bcoca Feb 14, 2022
6a63322
Fix bugs.
felixfontein Mar 16, 2022
d2ed6ad
Call _set_conn_data() when needed.
felixfontein Mar 18, 2022
243c933
Cache result of _get_docker_remote_user() now that it is called multi…
felixfontein Mar 18, 2022
5bee73c
Fix unit tests.
felixfontein Mar 18, 2022
a526d68
list.clear() is Python 3...
felixfontein Mar 18, 2022
ef0eaf9
Add changelog.
felixfontein Mar 18, 2022
82df729
Call _set_conn_data() also in _connect().
felixfontein Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/connection/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def _set_conn_data(self):

# TODO: this is mostly for backwards compatibility, play_context is used as fallback for older versions
# docker arguments
self._docker_args.clear()
del self._docker_args[:]
bcoca marked this conversation as resolved.
Show resolved Hide resolved
extra_args = self.get_option('docker_extra_args') or self._play_context.docker_extra_args
if extra_args:
self._docker_args += extra_args.split(' ')
Expand Down