Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #243/bed775c4 backport][stable-1] docker_container_exec: improve handling of chdir option #247

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 30, 2021

This is a backport of PR #243 as merged into main (bed775c).

SUMMARY

Only pass chdir on when it is provided, and prevent this option from being used for Docker SDK for Python < 3.0.0

The workdir option was added to exec_create in 3.0.0: docker/docker-py@abd60ae

Fixes #242.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container_exec

* Only pass chdir on when it is provided, and prevent this option from being used for Docker SDK for Python < 3.0.0.

* Also fix docker_api connection plugin.

(cherry picked from commit bed775c)
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #247 (bed775c) into stable-1 (3029ad3) will decrease coverage by 0.04%.
The diff coverage is 7.14%.

❗ Current head bed775c differs from pull request most recent head eca8722. Consider uploading reports for the commit eca8722 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           stable-1     #247      +/-   ##
============================================
- Coverage     73.54%   73.49%   -0.05%     
============================================
  Files            57       57              
  Lines          7912     7909       -3     
  Branches       1768     1767       -1     
============================================
- Hits           5819     5813       -6     
- Misses         1593     1595       +2     
- Partials        500      501       +1     
Flag Coverage Δ
integration 73.25% <62.50%> (-0.04%) ⬇️
sanity 16.99% <12.50%> (-0.01%) ⬇️
stub 0.00% <0.00%> (ø)
units 27.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.azure-pipelines/scripts/publish-codecov.py 0.00% <0.00%> (ø)
plugins/connection/docker_api.py 61.49% <ø> (ø)
plugins/module_utils/common.py 71.33% <ø> (-0.05%) ⬇️
plugins/modules/docker_host_info.py 88.88% <ø> (ø)
plugins/modules/docker_login.py 81.43% <ø> (+0.84%) ⬆️
...ts/docker_container/filter_plugins/ipaddr_tools.py 0.00% <0.00%> (ø)
plugins/modules/docker_container_exec.py 85.29% <50.00%> (-2.21%) ⬇️
plugins/modules/docker_container.py 76.57% <66.66%> (-0.10%) ⬇️
plugins/modules/docker_compose.py 53.39% <100.00%> (-0.11%) ⬇️
plugins/modules/docker_plugin.py 63.15% <0.00%> (-1.17%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23ef4a...eca8722. Read the comment docs.

@felixfontein felixfontein merged commit 9f36cf1 into stable-1 Nov 30, 2021
@felixfontein felixfontein deleted the patchback/backports/stable-1/bed775c4ea7be62ae3ffa620b478ffb67523fe7f/pr-243 branch November 30, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant