generated from ansible-collections/collection_template
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated features, bump version to 2.0.0 #210
Merged
felixfontein
merged 7 commits into
ansible-collections:main
from
felixfontein:deprecations
Oct 5, 2021
Merged
Remove deprecated features, bump version to 2.0.0 #210
felixfontein
merged 7 commits into
ansible-collections:main
from
felixfontein:deprecations
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
the
breaking_change
This PR contains a breaking change that MUST wait for the next major release
label
Sep 18, 2021
Open
felixfontein
force-pushed
the
deprecations
branch
from
October 5, 2021 06:39
fdc8892
to
bde09fc
Compare
felixfontein
changed the title
[2.0.0] Remove deprecated features
Remove deprecated features, bump version to 2.0.0
Oct 5, 2021
ready_for_review |
Ajpantuso
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Ajpantuso thanks for reviewing this! |
This was referenced Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove deprecated features in docker_container and docker_login that were scheduled for removal in 2.0.0. Also deprecates a feature in docker_container that was announced to be deprecated in 2.0.0.
This must not be merged until we start preparing 2.0.0, and stable-1 has been branched.
ISSUE TYPE
COMPONENT NAME
docker_container
docker_login