Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing anonymous volumes via mounts option #181

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Allowing anonymous volumes via mounts option #181

merged 2 commits into from
Jul 27, 2021

Conversation

Ajpantuso
Copy link
Collaborator

SUMMARY

Lifting restriction that source be required as a key for mounts when type: volume so that anonymous volumes can be created.

Requested in #175 here.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/docker_container.py

ADDITIONAL INFORMATION
  • Added integration tests for idempotency.

@Ajpantuso Ajpantuso changed the title [WIP] Allowing anonymous volumes via mounts option Allowing anonymous volumes via mounts option Jul 27, 2021
@Ajpantuso Ajpantuso marked this pull request as ready for review July 27, 2021 16:21
@felixfontein felixfontein merged commit b2430f7 into ansible-collections:main Jul 27, 2021
@felixfontein
Copy link
Collaborator

@Ajpantuso thanks for implementing this!

@Ajpantuso Ajpantuso deleted the docker_container_anon_volumes branch July 27, 2021 17:39
@renovate renovate bot mentioned this pull request Aug 3, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ajpantuso @felixfontein