-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-compose - Adding validated state and no_interpolate option #169
docker-compose - Adding validated state and no_interpolate option #169
Conversation
314d75e
to
2b2053d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that we should add this as a state. I think it would be better to have this as an _info
module; maybe docker_compose_validate_info
?
@@ -1,4 +0,0 @@ | |||
--- | |||
minor_changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase to latest main
so these 'fake' changes go away? They're making reviewing harder :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a real change. I missed moving this to changelogs/fragments
in #162 so now it's just hanging out in root after 1.8.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops. I completely missed that...
I'll do the move in a separate commit (and add a note that this was already added in 1.8.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll close this and look into an info module instead.
- The resulting configuration from one or more compose files. | ||
- Equivalent to the output of C(docker-compose config). | ||
returned: when success and I(state=validated) | ||
type: dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type: dict | |
type: dict | |
version_added: 1.9.0 |
Yeah, I also considered this. If I go that route then I guess it could be |
SUMMARY
Adds a new state
validated
along with a new optionno_interpolate
which is the equivalent ofdocker-compose config
Implements #24
ISSUE TYPE
COMPONENT NAME
plugins/modules/docker-compose.py
ADDITIONAL INFORMATION
check_mode
so thevalidated
state was extended to actually display output likedocker-compose config
.no-interpolate
adds the ability to show unsubstituted environment variables in theconfig
output.