Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_plugin - adding alias option and general cleanup #161

Merged
merged 2 commits into from
Jun 25, 2021
Merged

docker_plugin - adding alias option and general cleanup #161

merged 2 commits into from
Jun 25, 2021

Conversation

Ajpantuso
Copy link
Collaborator

SUMMARY

Adding an alias option to define a local name for a plugin.

Partial implementation of #145

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/docker_plugin.py

ADDITIONAL INFORMATION
  • Found some minor bugs when calling client.fail and addressed them
  • Updated the RETURN documentation with actions which was missing and implemented the plugin return value
  • Added integration tests.

@Ajpantuso Ajpantuso force-pushed the docker_plugin_alias branch from c95dcf4 to 0fd6228 Compare June 25, 2021 18:23
@Ajpantuso Ajpantuso marked this pull request as ready for review June 25, 2021 18:49
felixfontein
felixfontein approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@felixfontein felixfontein merged commit 825a4f7 into ansible-collections:main Jun 25, 2021
@felixfontein
Copy link
Collaborator

@Ajpantuso thanks a lot for implementing this!

@felixfontein felixfontein mentioned this pull request Sep 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ajpantuso @felixfontein