Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_host_info - Allow filters which are passed as lists #160

Merged

Conversation

Ajpantuso
Copy link
Collaborator

SUMMARY

Allows filter values which accept lists to be passed as lists to the docker API.
Fixes #18

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/docker_host_info.py

ADDITIONAL INFORMATION
  • Required an update to the common function clean_dict_booleans_for_docker_api, but previous behavior is defaulted so other modules are unaffected.
  • integration tests for filters were added as well.

@Ajpantuso Ajpantuso force-pushed the docker_host_info_filter_list branch from 974519c to 5631132 Compare June 21, 2021 23:20
@Ajpantuso Ajpantuso changed the title [WIP]: docker_host_info - Allow filters which are passed as lists docker_host_info - Allow filters which are passed as lists Jun 21, 2021
@Ajpantuso Ajpantuso marked this pull request as ready for review June 21, 2021 23:45
@Ajpantuso
Copy link
Collaborator Author

SUSE should clear on recheck.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/module_utils/common.py Outdated Show resolved Hide resolved
plugins/module_utils/common.py Outdated Show resolved Hide resolved
plugins/modules/docker_host_info.py Show resolved Hide resolved
@felixfontein felixfontein merged commit 49c8fd0 into ansible-collections:main Jun 22, 2021
@felixfontein
Copy link
Collaborator

@Ajpantuso thanks a lot for implementing this!

@Ajpantuso Ajpantuso deleted the docker_host_info_filter_list branch June 22, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker_host_info: Filter containers by multiple labels
2 participants