Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception handling #121

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Improve exception handling #121

merged 1 commit into from
Apr 8, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Use to_native() to convert exceptions to strings, not str(), nothing, or text_type().

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

all modules

@felixfontein
Copy link
Collaborator Author

CC @Andersson007

Andersson007
Andersson007 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@felixfontein felixfontein merged commit a3b9648 into ansible-collections:main Apr 8, 2021
@felixfontein felixfontein deleted the exceptions branch April 8, 2021 06:00
@felixfontein
Copy link
Collaborator Author

@Andersson007 thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @Andersson007