Determine the compose version via a CLI call and not the docker API.

[apollo13]

SUMMARY

Call the CLI to determine the compose version before talking to the API.
Refs #891

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

docker_compose_v2

[felixfontein]

Thanks for your contribution! Can you please add a changelog fragment? Thanks. (I think this is more like a feature than a bugfix though. The module was never supposed to work with Podman, so it's not a bug that it didn't work with it.)

Regarding the implementation: I think it would be a lot cleaner if you could move the code into multiple methods. One method get_docker_compose_version() (or similar) that calls docker compose version --formta jsonand returns the version as a string, or None if it cannot detemrine the version; and another method get_compose_plugin_version() (or similar) that contains the current code (and returns the version as a string, or fails). And maybe a third method which calls the other two and always returns the version as a string.

[apollo13]

Thanks for your contribution! Can you please add a changelog fragment? Thanks. (I think this is more like a feature than a bugfix though. The module was never supposed to work with Podman, so it's not a bug that it didn't work with it.)

Sure thing, I wanted to know whether it passes CI first :) Added it as minor_change.

Regarding the implementation: I think it would be a lot cleaner if you could move the code into multiple methods.

Done I think, let's see what CI says, locally it did work, but my test env is "limited" to a single python and docker.

[felixfontein]

Looks good! I've just have suggestion for the changelog fragment. This is about all docker_compose_v2* modules, not just docker_compose_v2 itself.

[felixfontein]

@apollo13 thanks for your contribution!

[apollo13]

Thank you for the quick turnaround and support (as always ;))