docker_swarm_service: flag secrets option as not secret #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There is a new sanity test which reports potentially secret-leaking module options. It flagged the
secrets
option of docker_swarm_service.I'm pretty sure that this option does not leak any secrets, so I'm marking it (and
secret_id
andsecret_filename
in it) asno_log=False
.@dariko @jwitko @hannseman @WojciechowskiPiotr please take a look whether this is correct :)
ISSUE TYPE
COMPONENT NAME
docker_swarm_service