Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_swarm_service: flag secrets option as not secret #102

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

There is a new sanity test which reports potentially secret-leaking module options. It flagged the secrets option of docker_swarm_service.

I'm pretty sure that this option does not leak any secrets, so I'm marking it (and secret_id and secret_filename in it) as no_log=False.

@dariko @jwitko @hannseman @WojciechowskiPiotr please take a look whether this is correct :)

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

docker_swarm_service

@felixfontein
Copy link
Collaborator Author

felixfontein commented Mar 12, 2021

(I have not added a changelog fragment since this should not be a user-facing change. If you disagree, I will add one :) ) Just decided to add one.

@WojciechowskiPiotr
Copy link
Collaborator

Looks fine, The Swarm Secret name is not leaking any sensitive data, it is just an object with the sensitive data inside. Merged.

@WojciechowskiPiotr WojciechowskiPiotr merged commit e42aadf into ansible-collections:main Mar 12, 2021
@felixfontein felixfontein deleted the secrets branch March 12, 2021 21:02
@felixfontein
Copy link
Collaborator Author

@WojciechowskiPiotr thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants