Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --template-driver for docker_config #332

Closed
willat8 opened this issue Apr 7, 2022 · 1 comment · Fixed by #345
Closed

Support --template-driver for docker_config #332

willat8 opened this issue Apr 7, 2022 · 1 comment · Fixed by #345
Labels
docker-swarm Docker Swarm enhancement New feature or request

Comments

@willat8
Copy link

willat8 commented Apr 7, 2022

SUMMARY

The --template-driver parameter set to golang when creating a docker config means we can create docker configs referencing environment variables, secrets and other information. Support for setting this in the docker_config module would be useful.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

docker_config

ADDITIONAL INFORMATION
@felixfontein felixfontein added the enhancement New feature or request label Apr 7, 2022
@felixfontein
Copy link
Collaborator

This shouldn't be too hard to implement, since Docker SDK for Python offers this: https://docker-py.readthedocs.io/en/stable/api.html#docker.api.config.ConfigApiMixin.create_config

@felixfontein felixfontein added the docker-swarm Docker Swarm label Apr 7, 2022
felixfontein pushed a commit that referenced this issue May 11, 2022
* initial templating changes

* adding docs

* author

* responding to pr comments

* testing for idempotency

* using template_driver rather than templating

* adding explicit idem check

* remove local testing changes

* bug fix

* fixing idempotency

Co-authored-by: Sasha Jenner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker-swarm Docker Swarm enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants