Increase # of bits for random serial numbers of certificates with PyOpenSSL backend #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready_for_review |
Closed
|
LGTM, though I wonder why one would set the lower limit at 2^160 instead of 0 for serial numbers? Seems to cut the whole possible range in half... |
|
It makes sure that the bitlength is always 161 bits ;-) It's more to make it similar to the old code (which never went below 1000). I don't mind removing that part. The chance that this is actually 0 is pretty low anyway. |
|
(Also always setting bit 160 is less bad as always setting bit 0 IMO, which is another common choice to make sure the serial cannot be 0 ;) ) |
|
I've adjusted the algorithm to return a <= 160bit number between 1000 and 2^160-1. |
|
@MarkusTeufelberger thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes part of #76. Instead of using a random number betwen 1000 and 99999 (both inclusive), selects a 160 bit random number between 2^160 and 2^161 - 1 (both inclusive). No special random input source is used, so the quality is not very high. I think that's ok for serial numbers of certificates (and already a lot better than what we had before).
ISSUE TYPE
COMPONENT NAME
openssl_certificate