cryptography backend: parse dirName, RID and otherName names #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2020
felixfontein
force-pushed
the
parse-dirname-rid-othername
branch
from
02250a5 to
af91030
Compare
felixfontein
force-pushed
the
parse-dirname-rid-othername
branch
2 times, most recently
from
c644f13 to
8a82414
Compare
felixfontein
force-pushed
the
parse-dirname-rid-othername
branch
from
8a82414 to
deb3d08
Compare
|
ready_for_review |
Closed
|
Looks good to me shipit |
|
@MarkusTeufelberger thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
(Port of ansible/ansible#67669 to community.crypto. I'm copying its description.)
These weren't supported so far. Prompted by a question on the ansible-project mailing list.
While adding tests, I noticed that it is pretty much impossible to use
dirNamewith the pyOpenSSL backend, since the functions are designed to work with a OpenSSL config file (the syntax isdirName:sectionName, andsectionNameis supposed to be a section name in that config file - not very helpful); and support forotherNameis only partial: while it supports more complex ways of specifying it (you can specify the ASN.1 type and the value in a readable form), it can't parse the result: it will always be printed as<unsupported>.ISSUE TYPE
COMPONENT NAME
plugins/module_utils/crypto.py
openssl_csr
openssl_csr_info
x509_certificate
x509_certificate_info