-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release #75
Prepare release #75
Conversation
The ignores in the sanity tests could also be deactivated I think? |
@MarkusTeufelberger did that in ec839dc (forgot to commit that before the first push...) |
Maybe a small "Roadmap/future deprecations" section in the README would be nice to have? On the other hand it is already quite clear that pyopenssl will be gone with 2.0.0 - still it could calm down some people by ensuring them that we aren't going to end support as long as there are upstream supported mainstream distributions (Debian, Ubuntu, CentOS, Fedora, Alpine, Arch, Suse, ...?) out there that wouldn't be able to run these modules with native packages. |
I've updated the README a bit, and fleshed out the roadmap section. |
Finally passes all tests :) |
@MarkusTeufelberger mind if I merge this? Or do you want to check the README.md changes first (or some other changes)? |
3. Add the directory containing `ansible_collections` to your [ANSIBLE_COLLECTIONS_PATHS](https://docs.ansible.com/ansible/latest/reference_appendices/config.html#collections-paths). | ||
3. Add the directory containing `ansible_collections` to your [ANSIBLE_COLLECTIONS_PATH](https://docs.ansible.com/ansible/latest/reference_appendices/config.html#collections-paths). | ||
|
||
See [Ansible's dev guide](https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#contributing-to-collections) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: Maybe we should not link to the "devel" version in the future here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. But the non-devel link does not exist yet (at least that anchor).
README.md
Outdated
|
||
## Release notes | ||
|
||
<!--Add a link to a changelog.md file or an external docsite to cover this information. --> | ||
See the [changelog](https://github.com/ansible-collections/collection_template/blob/master/CHANGELOG.rst). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dead link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will exist once the first release is created :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In collection_template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL, great catch! I really wonder where I copied that from...
shipit :-) |
@MarkusTeufelberger thanks a lot for reviewing this! |
SUMMARY
Do some generic cleanup; set deprecation versions to 2.0.0.
Fixes #73.
ISSUE TYPE
COMPONENT NAME
collection