Fix crash in x509_crl when certificate issuer is specified

[felixfontein]

SUMMARY

Found this while working on #436.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

x509_crl

[felixfontein]

entry['issuer'] is already transformed in line 530.

[briantist]

I was surprised that this plain scalar worked multi-line without > or >- or something... I did find at least one yaml parser online that didn't like it: https://codebeautify.org/yaml-validator/y22bd59f9

But it appears that validator is wrong; and it clearly works in Ansible regardless, but you may want to change it if only for consistency with the other asserts in the file.

Or not 🤷

[felixfontein]

According to the YAML definition this should be fine: https://yaml.org/spec/1.2.2/#plain-style
I'd probably rather remove the > from the other blocks in this file (but not in this PR) :)

[felixfontein]

@briantist thanks for reviewing this!

[patchback]

Backport to stable-1: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 9d03178 on top of patchback/backports/stable-1/9d03178b003ac3145f0af0c18c21ffca4992305c/pr-441

Backporting merged PR #441 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/community.crypto.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-1/9d03178b003ac3145f0af0c18c21ffca4992305c/pr-441 upstream/stable-1

4. Now, cherry-pick PR Fix crash in x509_crl when certificate issuer is specified #441 contents into that branch:

   $ git cherry-pick -x 9d03178b003ac3145f0af0c18c21ffca4992305c

   If it'll yell at you with something like fatal: Commit 9d03178b003ac3145f0af0c18c21ffca4992305c is a merge but no -m option was given., add -m 1 as follows intead:

   $ git cherry-pick -m1 -x 9d03178b003ac3145f0af0c18c21ffca4992305c

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Fix crash in x509_crl when certificate issuer is specified #441 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-1/9d03178b003ac3145f0af0c18c21ffca4992305c/pr-441

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.