Add EE support #440
Add EE support #440
Conversation
|
I didn't expect the cryptography coming with whatever RHEL the EE is based on to be that old (Oct 2019) :) |
|
Ok, I think we have two choices:
What do you think? |
|
One advantage of using the system libraries is that you can still force-install the PyPi versions over these if you want. |
|
After thinking about this for a longer time, I'd personally go with 1 - after all you can still explicitly force newer versions of cryptography and PyOpenSSL in the EE if you want to. |
|
I switched back to using system packages. |
| tests/ee/roles/smoke/library/smoke_ipaddress.py shebang | ||
| tests/ee/roles/smoke/library/smoke_pyyaml.py shebang |
There was a problem hiding this comment.
Did you see my comment in a previous one of these?
I don't know the reason why (maybe it's because they are in an integration target? or a setup_ target specifically?), but I do not have any shebang errors on modules I created for tests:
https://github.com/ansible-collections/community.hashi_vault/tree/main/tests/integration/targets/setup_vault_test_plugins/library
(some have a shebang, I think most don't, they all work)
There was a problem hiding this comment.
The reason is that this isn't in tests/integration/targets/.../library/ or plugins/modules/, but some other directory. The sanity check treats these directories specially: https://github.com/ansible/ansible/blob/devel/test/lib/ansible_test/_util/controller/sanity/code-smell/shebang.py#L84
| name: Build and test EE (Ⓐ${{ matrix.runner_tag }}) | ||
| strategy: | ||
| matrix: | ||
| runner_tag: |
There was a problem hiding this comment.
do they not have stable-2.13 yet?
There was a problem hiding this comment.
There isn't (https://quay.io/repository/ansible/ansible-runner?tab=tags&tag=latest). I guess it will show up once 2.13.0 has been released.
|
@briantist thanks a lot for reviewing this! |
SUMMARY
Try to make this collection EE ready, with tests. Similar to ansible-collections/community.dns#93.
ISSUE TYPE
COMPONENT NAME
collection