openssl_pkcs12: do not crash when there's no certificate and/or private key in existing PKCS#12 file #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadger
reviewed
Sep 14, 2020
|
As far as i can see without having actually run the code, this looks good now :-) |
|
The new tests also pass (except the macOS failure in CI, but that is unrelated to this PR - I'll have to investigate what that is...), so it should be good :) |
|
Looks like the failing CI was caused by cffi 1.14.3, which has been yanked. Unfortunately the pip version on macOS (8 something) does ignore that, since support for yanked packages was only added in pip 19.2... |
felixfontein
force-pushed
the
pkcs12-no-cert-key-crash
branch
from
3d1cb0c to
e983d49
Compare
|
(Rebased to remove test commits for fixing the macOS problem. That problem has now been fixed in |
|
@abadger thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #103.
ISSUE TYPE
COMPONENT NAME
openssl_pkcs12