-
Notifications
You must be signed in to change notification settings - Fork 90
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add persistent and perf options to the luks_device (#434)
Read and write work queue significantly degrades performance on SSD/NVME devices[1]. In Debian 11 crypttab does not support no-read-workqueue and no-write-workqueue flags, so the persistent flag is workaround: once opened with perf parameters persists forever. [1] https://blog.cloudflare.com/speeding-up-linux-disk-encryption/ Signed-off-by: Yauhen Artsiukhou <[email protected]>
- Loading branch information
Showing
3 changed files
with
171 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| minor_changes: | ||
| - luks_devices - added ``persistent`` option when opening LUKS2 containers (https://github.com/ansible-collections/community.crypto/pull/434). | ||
| - luks_devices - added ``perf_same_cpu_crypt``, ``perf_submit_from_crypt_cpus``, ``perf_no_read_workqueue``, ``perf_no_write_workqueue`` for performance tuning when opening LUKS2 containers (https://github.com/ansible-collections/community.crypto/issues/427). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
tests/integration/targets/luks_device/tasks/tests/performance.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| --- | ||
| - name: Gather package facts | ||
| package_facts: | ||
| manager: auto | ||
|
|
||
| - name: On kernel >= 5.9 use performance flags | ||
| block: | ||
| - name: Create and open (check) | ||
| luks_device: | ||
| device: "{{ cryptfile_device }}" | ||
| state: opened | ||
| keyfile: "{{ remote_tmp_dir }}/keyfile1" | ||
| perf_same_cpu_crypt: true | ||
| perf_submit_from_crypt_cpus: true | ||
| perf_no_read_workqueue: true | ||
| perf_no_write_workqueue: true | ||
| persistent: true | ||
| pbkdf: | ||
| iteration_time: 0.1 | ||
| check_mode: yes | ||
| become: yes | ||
| register: create_open_check | ||
| - name: Create and open | ||
| luks_device: | ||
| device: "{{ cryptfile_device }}" | ||
| state: opened | ||
| keyfile: "{{ remote_tmp_dir }}/keyfile1" | ||
| pbkdf: | ||
| iteration_time: 0.1 | ||
| perf_same_cpu_crypt: true | ||
| perf_submit_from_crypt_cpus: true | ||
| perf_no_read_workqueue: true | ||
| perf_no_write_workqueue: true | ||
| persistent: true | ||
| become: yes | ||
| register: create_open | ||
| - name: Create and open (idempotent) | ||
| luks_device: | ||
| device: "{{ cryptfile_device }}" | ||
| state: opened | ||
| keyfile: "{{ remote_tmp_dir }}/keyfile1" | ||
| pbkdf: | ||
| iteration_time: 0.1 | ||
| perf_same_cpu_crypt: true | ||
| perf_submit_from_crypt_cpus: true | ||
| perf_no_read_workqueue: true | ||
| perf_no_write_workqueue: true | ||
| persistent: true | ||
| become: yes | ||
| register: create_open_idem | ||
| - name: Create and open (idempotent, check) | ||
| luks_device: | ||
| device: "{{ cryptfile_device }}" | ||
| state: present | ||
| keyfile: "{{ remote_tmp_dir }}/keyfile1" | ||
| pbkdf: | ||
| iteration_time: 0.1 | ||
| perf_same_cpu_crypt: true | ||
| perf_submit_from_crypt_cpus: true | ||
| perf_no_read_workqueue: true | ||
| perf_no_write_workqueue: true | ||
| persistent: true | ||
| check_mode: yes | ||
| become: yes | ||
| register: create_open_idem_check | ||
| - assert: | ||
| that: | ||
| - create_open_check is changed | ||
| - create_open is changed | ||
| - create_open_idem is not changed | ||
| - create_open_idem_check is not changed | ||
|
|
||
| - name: Dump LUKS Header | ||
| command: "cryptsetup luksDump {{ cryptfile_device }}" | ||
| become: yes | ||
| register: luks_header | ||
| - assert: | ||
| that: | ||
| - "'no-read-workqueue' in luks_header.stdout" | ||
| - "'no-write-workqueue' in luks_header.stdout" | ||
| - "'same-cpu-crypt' in luks_header.stdout" | ||
| - "'submit-from-crypt-cpus' in luks_header.stdout" | ||
|
|
||
| - name: Dump device mapper table | ||
| command: "dmsetup table {{ create_open.name }}" | ||
| become: yes | ||
| register: dm_table | ||
| - assert: | ||
| that: | ||
| - "'no_read_workqueue' in dm_table.stdout" | ||
| - "'no_write_workqueue' in dm_table.stdout" | ||
| - "'same_cpu_crypt' in dm_table.stdout" | ||
| - "'submit_from_crypt_cpus' in dm_table.stdout" | ||
|
|
||
| - name: Closed and Removed | ||
| luks_device: | ||
| name: "{{ cryptfile_device }}" | ||
| state: absent | ||
| become: yes | ||
|
|
||
| when: | ||
| - ansible_facts.kernel is version('5.9.0', '>=') | ||
| - ansible_facts.packages['cryptsetup'][0].version is version('2.3.4', '>=') |