Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the name attribute value in the examples #918

Merged

Conversation

priyadarshu
Copy link
Contributor

SUMMARY

Problem-

  • All the examples had same name key value irrespective of different purposes of the tasks

Action taken -

  • Made changes in the name of the tasks under examples
  • Corrected it with relevant name key value to the comments of the task
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Updated the name attribute value in the YAML example
@Akasurde
Copy link
Member

Akasurde commented Feb 2, 2022

@jatorcasso Could you please review this? Thanks in advance.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (third-party-check pipeline).

Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Feb 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

@markuman markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Feb 2, 2022
@markuman
Copy link
Member

markuman commented Feb 2, 2022

@priyadarshu thank for your first controbution!

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Feb 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0e08a40 into ansible-collections:main Feb 2, 2022
@patchback
Copy link

patchback bot commented Feb 2, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/0e08a409083947386482ff8423e85c4226a40dba/pr-918

Backported as #919

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 2, 2022
Update the name attribute value in the examples

SUMMARY

Problem-

All the examples had same name key value irrespective of different purposes of the tasks

Action taken -

Made changes in the name of the tasks under examples
Corrected it with relevant  name key value to the comments of the task

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 0e08a40)
@patchback
Copy link

patchback bot commented Feb 2, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/0e08a409083947386482ff8423e85c4226a40dba/pr-918

Backported as #920

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 2, 2022
Update the name attribute value in the examples

SUMMARY

Problem-

All the examples had same name key value irrespective of different purposes of the tasks

Action taken -

Made changes in the name of the tasks under examples
Corrected it with relevant  name key value to the comments of the task

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 0e08a40)
@Akasurde
Copy link
Member

Akasurde commented Feb 3, 2022

@priyadarshu Thanks for working on this.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 3, 2022
[PR #918/0e08a409 backport][stable-3] Update the name attribute value in the examples

This is a backport of PR #918 as merged into main (0e08a40).
SUMMARY

Problem-

All the examples had same name key value irrespective of different purposes of the tasks

Action taken -

Made changes in the name of the tasks under examples
Corrected it with relevant  name key value to the comments of the task


ISSUE TYPE


Docs Pull Request

COMPONENT NAME




ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 4, 2022
[PR #918/0e08a409 backport][stable-2] Update the name attribute value in the examples

This is a backport of PR #918 as merged into main (0e08a40).
SUMMARY

Problem-

All the examples had same name key value irrespective of different purposes of the tasks

Action taken -

Made changes in the name of the tasks under examples
Corrected it with relevant  name key value to the comments of the task


ISSUE TYPE


Docs Pull Request

COMPONENT NAME




ADDITIONAL INFORMATION
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
)

Update the name attribute value in the examples

SUMMARY

Problem-

All the examples had same name key value irrespective of different purposes of the tasks

Action taken -

Made changes in the name of the tasks under examples
Corrected it with relevant  name key value to the comments of the task

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@0e08a40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch community_review docs mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants