Move some shared logic in module utils/sns #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
module_utils/sns
branch
from
5b74ae0 to
8371c01
Compare
tremble
requested changes
Jan 21, 2022
There was a problem hiding this comment.
I'm running a slightly stricter set of pylint tests locally that I think are worth fixing:
ERROR: plugins/module_utils/sns.py:125:0: missing-final-newline: Final newline missing
ERROR: plugins/modules/sns_topic.py:287:0: unused-import: Unused import re
ERROR: plugins/modules/sns_topic.py:288:0: unused-import: Unused import copy
|
(but otherwise looks good) |
Signed-off-by: Alina Buzachis <[email protected]>
tremble
approved these changes
Jan 21, 2022
marknet15
reviewed
Jan 21, 2022
Signed-off-by: Alina Buzachis <[email protected]>
markuman
approved these changes
Jan 28, 2022
markuman
added
mergeit
|
recheck |
ansibullbot
added
community_review
feature
|
Build failed.
|
Signed-off-by: Alina Buzachis <[email protected]>
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
sns_topic_info new module SUMMARY sns_topic_info - new module allowing to get all AWS SNS topics or properties of a specific AWS SNS topic. Fixes #601 Requires #879 ISSUE TYPE New Module Pull Request COMPONENT NAME sns_topic_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
sns_topic_info new module SUMMARY sns_topic_info - new module allowing to get all AWS SNS topics or properties of a specific AWS SNS topic. Fixes #601 Requires #879 ISSUE TYPE New Module Pull Request COMPONENT NAME sns_topic_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 58b3c68)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Backport: Move some shared logic in module utils/sns (#879) SUMMARY Backport Move some shared logic in module utils/sns (#879) to stable-3 ISSUE TYPE Feature Pull Request COMPONENT NAME sns_topic sns sns_topic_info Reviewed-by: Mark Chappell Reviewed-by: Mark Woolley Reviewed-by: Markus Bergholz Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
[PR #673/58b3c687 backport][stable-3] sns_topic_info new module This is a backport of PR #673 as merged into main (58b3c68). SUMMARY sns_topic_info - new module allowing to get all AWS SNS topics or properties of a specific AWS SNS topic. Fixes #601 Requires #879 ISSUE TYPE New Module Pull Request COMPONENT NAME sns_topic_info Reviewed-by: Mark Woolley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Move some shared logic in module utils/sns
ISSUE TYPE
COMPONENT NAME
sns_topic
sns
sns_topic_info