Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform to ecs service #353

Merged
merged 6 commits into from
Mar 29, 2021
Merged

Add platform to ecs service #353

merged 6 commits into from
Mar 29, 2021

Conversation

duderamos
Copy link
Contributor

@duderamos duderamos commented Jan 10, 2021 •
edited by goneri
Loading

SUMMARY

Closes: #136

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_service

@duderamos duderamos mentioned this pull request Jan 10, 2021
Closed
@duderamos
Copy link
Contributor Author

In order to address this conversation, I removed the list of choices and added a reference to official documentation.

@markuman
Copy link
Member

You need a changelog fragment and you add version_added to the documentation.

@ansibullbot
Copy link

cc @Java1Guy @jillr @kaczynskid @s-hertel @tremble @wimnat @zacblazic
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 13, 2021
@duderamos
Copy link
Contributor Author

Hey @markuman, thanks for your feedback. I added a changelog fragment, but I'm unsure about you add version_added to the documentation part. The module that I changed already has a version_added and I couldn't find an example from other recent PRs regarding this matter. Can you please clarify?

@duderamos
Copy link
Contributor Author

Hey @tremble , could you check this for me please?

@jillr
Copy link
Collaborator

jillr commented Feb 11, 2021

The module that I changed already has a version_added and I couldn't find an example from other recent PRs regarding this matter. Can you please clarify?

version_added can also be added at the option level, to show which collection release it was added in. You can see it in ec2_vol here:
https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/ec2_vol.py#L95-L107
We'll be releasing 1.4.0 in the next few days, so this would likely need to be 1.5.0

@alinabuzachis alinabuzachis mentioned this pull request Feb 24, 2021
Merged
tremble
tremble approved these changes Mar 29, 2021
View reviewed changes
plugins/modules/ecs_service.py Show resolved Hide resolved
@tremble
Copy link
Contributor

tremble commented Mar 29, 2021

#340 looks like it still needs work. Since this PR looks like it's ready to roll I'll merge it and deployment controller can be separately managed.

@tremble tremble merged commit 515ca23 into ansible-collections:main Mar 29, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@duderamos
Add platform to ecs service (ansible-collections#353)
b0346db 
* Add platformVersion params to ecs_service
* Add changelog fragment
* Add version_added
Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@duderamos
Add platform to ecs service (ansible-collections#353)
2457794 
* Add platformVersion params to ecs_service
* Add changelog fragment
* Add version_added
Co-authored-by: Mark Chappell <[email protected]>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@duderamos @danielcotton
Add platform to ecs service (ansible-collections#353)
2f9ebd4 
* Add platformVersion params to ecs_service
* Add changelog fragment
* Add version_added
Co-authored-by: Mark Chappell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@jillr jillr Awaiting requested review from jillr

@goneri goneri Awaiting requested review from goneri

@gravesm gravesm Awaiting requested review from gravesm

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ecs_service does not support the platform-version option
6 participants
@duderamos @markuman @ansibullbot @jillr @tremble @goneri