Fix parameters with aliases not being passed (#92)

Fix parameters with aliases not being passed Depends-On: ansible/ansible-zuul-jobs#1176 SUMMARY The recently added _is_an_alias() function should check whether the current key is in the list of aliases. Fixes: #91 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: None <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
ansible-collections · Oct 12, 2021 · 7bad786 · 7bad786
1 parent 4c2b7de
commit 7bad786
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/changelogs/fragments/92-fix-params-with-aliases.yml b/changelogs/fragments/92-fix-params-with-aliases.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - fix parameters with aliases not being passed through (https://github.com/ansible-collections/cloud.common/issues/91).
diff --git a/plugins/module_utils/turbo/module.py b/plugins/module_utils/turbo/module.py
@@ -80,7 +80,7 @@ def _keep_value(v, argument_specs, key, subkey=None):
 
     def _is_an_alias(k):
         aliases = argument_specs[k].get("aliases")
-        return aliases and k != aliases[0]
+        return aliases and k in aliases
 
     new_params = {}
     for k, v in params.items():

diff --git a/tests/unit/module_utils/test_turbo_module.py b/tests/unit/module_utils/test_turbo_module.py
@@ -129,9 +129,12 @@ def test_prepare_args_subkey_with_default():
 
 
 def test_prepare_args_dedup_aliases():
-    argspec = {
-        "foo": {"aliases": ["bar"], "type": int},
-        "bar": {"aliases": ["bar"], "type": int},
-    }
+    argspec = {"foo": {"aliases": ["bar"], "type": int}}
     params = {"foo": 1, "bar": 1}
-    assert prepare_args(argspec, params) == {"ANSIBLE_MODULE_ARGS": {"bar": 1}}
+    assert prepare_args(argspec, params) == {"ANSIBLE_MODULE_ARGS": {"foo": 1}}
+
+
+def test_prepare_args_with_aliases():
+    argspec = {"foo": {"aliases": ["bar"], "type": int}}
+    params = {"foo": 1}
+    assert prepare_args(argspec, params) == {"ANSIBLE_MODULE_ARGS": {"foo": 1}}