eos_interfaces: Fix issue with 'forced' speed configuration. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomathiselviS
changed the title
Qalthos
approved these changes
Sep 30, 2020
Signed-off-by: GomathiselviS <[email protected]>
GomathiselviS
force-pushed
the
interfaces_speed
branch
from
c69a1d8 to
61815e1
Compare
|
Thanks for working on this! (Btw, |
|
I have successfully tested this in our environment and can confirm that this fixes #117. |
GomathiselviS
added a commit
to GomathiselviS/eos
that referenced
this pull request
Jan 21, 2021
This reverts commit bfe00bf. Revert "Revert "Change short desction (ansible-collections#123)"" This reverts commit 90c7d21. eos_interfaces: Fix issue with 'forced' speed configuration. (ansible-collections#120) eos_interfaces: Fix issue with 'forced' speed configuration. Reviewed-by: https://github.com/apps/ansible-zuul Add documentation to use the l2_interfaces module for L2 configs, in l3_interfaces module. (ansible-collections#102) Add documentation to use the l2_interfaces module for L2 configs, in l3_interfaces module. Reviewed-by: https://github.com/apps/ansible-zuul Remove local connection testing for integration jobs (ansible-collections#127) Remove local connection testing for integration jobs Reviewed-by: https://github.com/apps/ansible-zuul Drop ansible from requirement.txt (ansible-collections#128) Drop ansible from requirement.txt Reviewed-by: https://github.com/apps/ansible-zuul Add eos_ospf_interfaces resource module (ansible-collections#125) Add eos_ospf_interfaces resource module Reviewed-by: https://github.com/apps/ansible-zuul Release prep version 1.2.0 (ansible-collections#129) Release prep version 1.2.0 Reviewed-by: https://github.com/apps/ansible-zuul Add version key to galaxy.yaml (ansible-collections#132) Add version key to galaxy.yaml Reviewed-by: https://github.com/apps/ansible-zuul To fix the bug where description was being parsed incorrectly as Interface in of eos_*_interfaces (ansible-collections#140) To fix the bug where description was being parsed incorrectly as Interface in of eos_*_interfaces Reviewed-by: https://github.com/apps/ansible-zuul Fix list.copy() and idempotent issues (replaced and overridden) (ansible-collections#142) Fix list.copy() and idempotent issues (replaced and overridden) Reviewed-by: https://github.com/apps/ansible-zuul Update default values in module argspec and docs Signed-off-by: GomathiselviS <[email protected]> linters fix
GomathiselviS
added a commit
to GomathiselviS/eos
that referenced
this pull request
Jan 22, 2021
This reverts commit bfe00bf. Revert "Revert "Change short desction (ansible-collections#123)"" This reverts commit 90c7d21. eos_interfaces: Fix issue with 'forced' speed configuration. (ansible-collections#120) eos_interfaces: Fix issue with 'forced' speed configuration. Reviewed-by: https://github.com/apps/ansible-zuul Add documentation to use the l2_interfaces module for L2 configs, in l3_interfaces module. (ansible-collections#102) Add documentation to use the l2_interfaces module for L2 configs, in l3_interfaces module. Reviewed-by: https://github.com/apps/ansible-zuul Remove local connection testing for integration jobs (ansible-collections#127) Remove local connection testing for integration jobs Reviewed-by: https://github.com/apps/ansible-zuul Drop ansible from requirement.txt (ansible-collections#128) Drop ansible from requirement.txt Reviewed-by: https://github.com/apps/ansible-zuul Add eos_ospf_interfaces resource module (ansible-collections#125) Add eos_ospf_interfaces resource module Reviewed-by: https://github.com/apps/ansible-zuul Release prep version 1.2.0 (ansible-collections#129) Release prep version 1.2.0 Reviewed-by: https://github.com/apps/ansible-zuul Add version key to galaxy.yaml (ansible-collections#132) Add version key to galaxy.yaml Reviewed-by: https://github.com/apps/ansible-zuul To fix the bug where description was being parsed incorrectly as Interface in of eos_*_interfaces (ansible-collections#140) To fix the bug where description was being parsed incorrectly as Interface in of eos_*_interfaces Reviewed-by: https://github.com/apps/ansible-zuul Fix list.copy() and idempotent issues (replaced and overridden) (ansible-collections#142) Fix list.copy() and idempotent issues (replaced and overridden) Reviewed-by: https://github.com/apps/ansible-zuul update docs Signed-off-by: GomathiselviS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GomathiselviS [email protected]
SUMMARY
Fixes : #117
When speed configuration for the interface changes from
xtoforced x, the value for duplex is also passed to theadd_configfunc (after necessary checks).ISSUE TYPE
COMPONENT NAME
eos_interfaces
ADDITIONAL INFORMATION