eos_ospfv3 resource module #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GomathiselviS <[email protected]> ospfv3_facts eos_ospfv3 config merged ospfv3 replaced state eos_ospfv3 config
GomathiselviS
force-pushed
the
rm_ospfv3
branch
from
12394fb to
8a23ceb
Compare
GomathiselviS
changed the title
GomathiselviS
changed the title
plugins/modules/eos_ospfv3.py
Outdated
| short_description: Manages OSPFv3 resource module | ||
| description: This module configures and manages the attributes of ospfv3 on Arista | ||
| EOS platforms. | ||
| version_added: 1.0.0 |
There was a problem hiding this comment.
Need to confirm whether this should be 1.2.0
plugins/modules/eos_ospfv3.py
Outdated
| """ | ||
| module = AnsibleModule( | ||
| argument_spec=Ospfv3Args.argument_spec, | ||
| mutually_exclusive=[], |
There was a problem hiding this comment.
How we are taking care of provided empty config.
NilashishC
reviewed
Sep 28, 2020
| @@ -0,0 +1,11 @@ | |||
| router ospfv3 | |||
There was a problem hiding this comment.
Should this be indented?
NilashishC
reviewed
Sep 29, 2020
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| major_changes: | |||
There was a problem hiding this comment.
Should this be a minor change? I'm not sure if major_changes would entail a major version bump.
|
Not a blocker but coverage for rm_templates/ospfv3 is at 40%, it'd be nice to increase that in the future. |
ya , I will work on it. |
rohitthakur2590
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Closes #69
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION