win_updates - use pipe for progress output and fix some connection stability problems #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jborean93
changed the title
jborean93
force-pushed
the
win_updates-pipe
branch
2 times, most recently
from
ddb2a01 to
2d9ec01
Compare
Changes the win_updates progress handler to use an ephemeral named pipe instead of temporary files. This should fix up problems with the action plugin trying to cleanup the file on a failure as there is now nothing to cleanup. The logging mechanism for the module has also been expanded to cover more scenarios around the background process that was missing before. This should make it more viable to debug failing scenarios than it was before. More error handling around broken connections or other connection problems that installing updates can introduce have been added. It should make the update process more resiliant than before.
jborean93
force-pushed
the
win_updates-pipe
branch
from
2d9ec01 to
12b72af
Compare
This was referenced Aug 16, 2023
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a bunch of issues with
win_updatesin regards to temporary files, read/connection issues during polling, and some deadlocks. It also tries to expose more unknown issues back to the user and expand on the debug logs in case of any more complex failures.Fixes #190 - the polling stage does a retry on a connection error/read timeout
Fixes #264 - same as above
Fixes #463 - I wasn't able to replicate the problem but the way the async tasks have changed should mitigate this problem
Fixes #524 - The progress output and wait mechanism has been completely rewritten
Fixes #527 - The bootstrapping code has been rewritten, if still a problem it should be returned back to the user
ISSUE TYPE
COMPONENT NAME
win_updates