New PersistentConnectionBase base plugin #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qalthos
force-pushed
the
persistentbase
branch
3 times, most recently
from
cbfffda to
4a7a7c5
Compare
maxamillion
approved these changes
Nov 1, 2022
maxamillion
approved these changes
Nov 1, 2022
maxamillion
approved these changes
Nov 2, 2022
|
shipit |
Qalthos
force-pushed
the
persistentbase
branch
from
4a7a7c5 to
b96417c
Compare
rohitthakur2590
approved these changes
Nov 3, 2022
This was referenced Nov 4, 2022
Closed
Closed
ghost
mentioned this pull request
1 task
This was referenced Nov 5, 2022
This was referenced Nov 16, 2022
Closed
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This will be NetworkConnectionBase's superclass when netcommon can switch to it.
ISSUE TYPE