Adjust booleans from yes/no to true/false #978

alinabuzachis · 2022-08-25T12:03:20Z

SUMMARY

As per ansible-community/community-topics#116

See also ansible-collections/community.aws#1420

Closes: #1041

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

several

ADDITIONAL INFORMATION

github-actions · 2022-08-25T12:05:27Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

ansibullbot · 2022-08-25T12:17:52Z

softwarefactory-project-zuul · 2022-08-25T12:58:07Z

Build failed.

softwarefactory-project-zuul · 2022-08-25T16:21:22Z

Build failed.

alinabuzachis · 2022-08-26T11:18:24Z

recheck

softwarefactory-project-zuul · 2022-08-26T12:50:54Z

Build failed.

alinabuzachis · 2022-08-26T14:39:35Z

recheck

goneri · 2022-08-26T15:56:05Z

Hi @alinabuzachis, for the record #979 addresses the timeout problem.

softwarefactory-project-zuul · 2022-08-26T16:11:58Z

Build failed.

tremble · 2022-08-30T08:36:31Z

recheck

softwarefactory-project-zuul · 2022-08-30T09:44:30Z

Build failed.

alinabuzachis · 2022-08-30T10:36:27Z

recheck

softwarefactory-project-zuul · 2022-08-30T11:40:17Z

Build failed.

abikouo

LGTM

softwarefactory-project-zuul · 2022-09-06T11:30:00Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

softwarefactory-project-zuul · 2022-09-06T18:18:56Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/amazon.aws for 978,3303072c857556060bbeb9464aae8c9650d9c6fd

softwarefactory-project-zuul · 2022-09-07T12:47:31Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

alinabuzachis · 2022-09-09T16:19:49Z

regate

softwarefactory-project-zuul · 2022-09-09T17:30:51Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

alinabuzachis · 2022-09-13T11:32:17Z

regate

softwarefactory-project-zuul · 2022-09-13T12:19:44Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

alinabuzachis · 2022-09-13T12:34:13Z

@goneri One of the ec2_instance tests is constantly failing here.

goneri · 2022-09-13T16:28:10Z

Hi @alinabuzachis,

The problem comes from ec2_vol, the disk stays with the attaching status till the end. attach_volume() expects the attached volume instead and so it retries to add the volume thus the error.

As far as I understand, attach_volume() is supposed to wait till the volume is actually connected:

amazon.aws/plugins/modules/ec2_vol.py

Lines 554 to 555 in d73b395

    
           waiter = ec2_conn.get_waiter('volume_in_use') 
        
           waiter.wait(VolumeIds=[attach_response['VolumeId']])

I'm not sure if it's some sporadic API inconsistency or a recent change somewhere.

goneri · 2022-09-13T16:28:57Z

regate

goneri · 2022-09-13T16:41:19Z

Regarding the TIMED_OUT errors, it looks the tests are slower than usual. We can try to run less targets in the same jobs if the problem occures too often.

softwarefactory-project-zuul · 2022-09-13T17:20:45Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

goneri · 2022-09-13T21:01:02Z

2022-09-13 16:49:24.097530 | controller | TASK [ec2_instance_instance_multiple : assert] *********************************
2022-09-13 16:49:24.097535 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml:163
2022-09-13 16:49:24.153029 | controller | fatal: [testhost]: FAILED! => {
2022-09-13 16:49:24.153068 | controller |     "assertion": "create_multiple_instances is not changed",
2022-09-13 16:49:24.153075 | controller |     "changed": false,
2022-09-13 16:49:24.153081 | controller |     "evaluated_to": false,
2022-09-13 16:49:24.153086 | controller |     "msg": "Assertion failed"
2022-09-13 16:49:24.153090 | controller | }

This looks like a similar problem. Enforce instance count - launch 5 instances line 55 creates the 5 instances with the status pending. I'm not sure why it doesn't wait.

2022-09-13 16:49:22.761417 | controller | "state": {
2022-09-13 16:49:22.761423 | controller | "code": 0,
2022-09-13 16:49:22.761428 | controller | "name": "pending"
2022-09-13 16:49:22.761438 | controller | },

And so when the Enforce instance count - launch 5 instances (check_mode - Idempotency) task comes after, it doesnt see any instance ready and assumes they need to be created.

tremble · 2022-09-15T07:23:21Z

regate

softwarefactory-project-zuul · 2022-09-15T09:05:44Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

tests: some ec2_instance targets are slower than normal Depends-On: ansible/ansible-zuul-jobs#1625 Dedicate more time for the execution of some slow ec2_instance targets. See: #978 (comment)

goneri · 2022-09-20T19:55:11Z

recheck

softwarefactory-project-zuul · 2022-09-20T21:03:26Z

Build failed.

tremble · 2022-09-21T09:10:02Z

recheck

softwarefactory-project-zuul · 2022-09-21T10:17:14Z

Build failed.

Signed-off-by: Alina Buzachis <[email protected]>

…gate

softwarefactory-project-zuul · 2022-09-21T15:07:53Z

Build succeeded.

softwarefactory-project-zuul · 2022-09-21T17:25:56Z

Build succeeded (gate pipeline).

patchback · 2022-09-21T17:26:01Z

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b4298bd on top of patchback/backports/stable-3/b4298bddef81caf7739e951defb62af0fbd12d5a/pr-978

Backporting merged PR #978 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-3/b4298bddef81caf7739e951defb62af0fbd12d5a/pr-978 upstream/stable-3

Now, cherry-pick PR Adjust booleans from yes/no to true/false #978 contents into that branch:
```
$ git cherry-pick -x b4298bddef81caf7739e951defb62af0fbd12d5a
```
If it'll yell at you with something like fatal: Commit b4298bddef81caf7739e951defb62af0fbd12d5a is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x b4298bddef81caf7739e951defb62af0fbd12d5a
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Adjust booleans from yes/no to true/false #978 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-3/b4298bddef81caf7739e951defb62af0fbd12d5a/pr-978

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2022-09-21T17:26:06Z

Backport to stable-4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b4298bd on top of patchback/backports/stable-4/b4298bddef81caf7739e951defb62af0fbd12d5a/pr-978

Backporting merged PR #978 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-4/b4298bddef81caf7739e951defb62af0fbd12d5a/pr-978 upstream/stable-4

Now, cherry-pick PR Adjust booleans from yes/no to true/false #978 contents into that branch:
```
$ git cherry-pick -x b4298bddef81caf7739e951defb62af0fbd12d5a
```
If it'll yell at you with something like fatal: Commit b4298bddef81caf7739e951defb62af0fbd12d5a is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x b4298bddef81caf7739e951defb62af0fbd12d5a
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Adjust booleans from yes/no to true/false #978 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-4/b4298bddef81caf7739e951defb62af0fbd12d5a/pr-978

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Update bools documentation in ec2_instance SUMMARY See also #1041 ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Split from #978 to work around CI issues Reviewed-by: Alina Buzachis <None>

ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Aug 25, 2022

tremble approved these changes Aug 25, 2022

View reviewed changes

tremble added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Aug 25, 2022

ansibullbot removed the needs_triage label Aug 25, 2022

abikouo approved these changes Sep 1, 2022

View reviewed changes

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Sep 6, 2022

goneri approved these changes Sep 6, 2022

View reviewed changes

ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review labels Sep 6, 2022

goneri mentioned this pull request Sep 13, 2022

tests: some ec2_instance targets are slower than normal #1019

Merged

alinabuzachis and others added 3 commits September 21, 2022 16:03

Adjust booleans

ecfa859

Signed-off-by: Alina Buzachis <[email protected]>

add changelog

bf328dc

Remove ec2_instance from big PR, improves the chance of a successful …

b788096

…gate

tremble force-pushed the update_bools branch from d6f8de4 to b788096 Compare September 21, 2022 14:05

softwarefactory-project-zuul bot merged commit b4298bd into ansible-collections:main Sep 21, 2022

tremble mentioned this pull request Sep 22, 2022

Update bools documentation in ec2_instance #1055

Merged

Adjust booleans from yes/no to true/false #978

Adjust booleans from yes/no to true/false #978

Conversation

alinabuzachis commented Aug 25, 2022 • edited by goneri Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented Aug 25, 2022 • edited Loading

Docs Build 📝

ansibullbot commented Aug 25, 2022

softwarefactory-project-zuul bot commented Aug 25, 2022

softwarefactory-project-zuul bot commented Aug 25, 2022

alinabuzachis commented Aug 26, 2022

softwarefactory-project-zuul bot commented Aug 26, 2022

alinabuzachis commented Aug 26, 2022

goneri commented Aug 26, 2022

softwarefactory-project-zuul bot commented Aug 26, 2022

tremble commented Aug 30, 2022

softwarefactory-project-zuul bot commented Aug 30, 2022

alinabuzachis commented Aug 30, 2022

softwarefactory-project-zuul bot commented Aug 30, 2022

abikouo left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Sep 6, 2022

softwarefactory-project-zuul bot commented Sep 6, 2022

softwarefactory-project-zuul bot commented Sep 7, 2022

alinabuzachis commented Sep 9, 2022

softwarefactory-project-zuul bot commented Sep 9, 2022

alinabuzachis commented Sep 13, 2022

softwarefactory-project-zuul bot commented Sep 13, 2022

alinabuzachis commented Sep 13, 2022

goneri commented Sep 13, 2022

goneri commented Sep 13, 2022

goneri commented Sep 13, 2022

softwarefactory-project-zuul bot commented Sep 13, 2022

goneri commented Sep 13, 2022 • edited Loading

tremble commented Sep 15, 2022

softwarefactory-project-zuul bot commented Sep 15, 2022

goneri commented Sep 20, 2022

softwarefactory-project-zuul bot commented Sep 20, 2022

tremble commented Sep 21, 2022

softwarefactory-project-zuul bot commented Sep 21, 2022

softwarefactory-project-zuul bot commented Sep 21, 2022

softwarefactory-project-zuul bot commented Sep 21, 2022

patchback bot commented Sep 21, 2022 • edited Loading

Backport to stable-3: 💔 cherry-picking failed — conflicts found

Backporting merged PR #978 into main

patchback bot commented Sep 21, 2022 • edited Loading

Backport to stable-4: 💔 cherry-picking failed — conflicts found

Backporting merged PR #978 into main

alinabuzachis commented Aug 25, 2022 •

edited by goneri

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

goneri commented Sep 13, 2022 •

edited

Loading

patchback bot commented Sep 21, 2022 •

edited

Loading

patchback bot commented Sep 21, 2022 •

edited

Loading