Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #928/524129fc backport][stable-3] ec2_instance - expand use of AWSRetry #930

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 15, 2022

This is a backport of PR #928 as merged into main (524129f).

SUMMARY

fixes: #927

A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

ec2_instance - expand use of AWSRetry

SUMMARY
fixes: #927
A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Brian Scholer <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 524129f)
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jul 15, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Jul 18, 2022
@tremble
Copy link
Contributor

tremble commented Jul 18, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 40s
✔️ build-ansible-collection SUCCESS in 4m 59s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 12m 47s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 30s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 29s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 31s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 00s
✔️ ansible-test-splitter SUCCESS in 2m 42s
✔️ integration-amazon.aws-1 SUCCESS in 45m 29s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 54c32f5 into stable-3 Jul 18, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/524129fcb5a8cebcea735cc0c83813205e0a160e/pr-928 branch July 18, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants