ARN: Add Support for the aws/aws-managed 'account' special cases #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
abikouo
approved these changes
Apr 5, 2022
|
regate |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ions Docs - cleanup Ansible Version related docs SUMMARY We had some free-form docs entries referring to old versions of Ansible which pre-date the collection. In line with removing the version_added data from prior to the collection's existence, remove these. Additionally we had a mix of Ansible version (in free-form docs) and Date deprecations (in module.deprecate), move these all over to dates. ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_kms.py plugins/modules/cloudfront_info.py plugins/modules/ec2_lc.py plugins/modules/ecs_taskdefinition.py plugins/modules/elb_network_lb.py plugins/modules/iam_policy.py plugins/modules/iam_role.py plugins/modules/route53.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ions Docs - cleanup Ansible Version related docs SUMMARY We had some free-form docs entries referring to old versions of Ansible which pre-date the collection. In line with removing the version_added data from prior to the collection's existence, remove these. Additionally we had a mix of Ansible version (in free-form docs) and Date deprecations (in module.deprecate), move these all over to dates. ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/aws_kms.py plugins/modules/cloudfront_info.py plugins/modules/ec2_lc.py plugins/modules/ecs_taskdefinition.py plugins/modules/elb_network_lb.py plugins/modules/iam_policy.py plugins/modules/iam_role.py plugins/modules/route53.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AWS has a couple of special cases for accounts in ARNs where they're named instead of just numbers.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/arn.py
ADDITIONAL INFORMATION
This code isn't part of a release yet, no need for a changelog