Improve doc to show support for IPv6 CIDR block #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
tremble
previously requested changes
Jan 24, 2022
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
@alinabuzachis , FYI this PR will fail integration tests until #631 is merged. |
| - cidr: 10.228.231.0/24 | ||
| assign_instances_ipv6: true | ||
| # Carve first /64 subnet of the Amazon-provided CIDR for the VPC. | ||
| ipv6_cidr: "{{ vpc_ipv6_cidr_block | ansible.netcommon.ipsubnet(64, 1) }}" |
There was a problem hiding this comment.
Initially I was testing with a /120 prefix length, not a /64.
However, that caused the test to be stuck, and I uncovered ansible-collections/ansible.utils#132 and netaddr/netaddr#241
ansibullbot
added
bug
alinabuzachis
added
the
backport-3
alinabuzachis
approved these changes
Mar 21, 2022
|
@sebastien-rosset this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
…s for IPv6 route table
Co-authored-by: Mark Chappell <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
sebastien-rosset
force-pushed
the
route_table_ipv6
branch
from
25c4e19 to
eddce97
Compare
ansibullbot
added
community_review
and removed
needs_rebase
|
recheck |
alinabuzachis
added
the
backport-2
alinabuzachis
added
mergeit
jillr
approved these changes
Mar 25, 2022
|
regate |
1 similar comment
|
regate |
alinabuzachis
dismissed
tremble’s stale review
It seems it stucks gating this PR.
|
regate |
|
regate |
|
regate |
Backport to stable-2: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c06d77c on top of patchback/backports/stable-2/c06d77c94a70a767566464b299410a27ea55f3e1/pr-634 Backporting merged PR #634 into main
🤖 @patchback |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #751 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Improve doc to show support for IPv6 CIDR block SUMMARY Improve doc to show IPv6 CIDR blocks are supported. Add example with IPv6 CIDR block. Add missing attribute to return values. Remove duplicate assertions in integration tests. Add tests for IPv6 subnets in integration tests. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_route_table ADDITIONAL INFORMATION While testing IPv6 in this module, I discovered the ipsubnet filter does not work if the prefix length has a fairly high value such as /120. I was running an integration test with a /120 subnet in this PR, but the ipsubnet call never returns and uses 100% CPU. I changed the value to a /64 subnet so this PR can pass. The ipsubnet issue needs to be fixed in ansible.netcommon and the netaddr package. I've created a unit test to reproduce the problem: ansible-collections/ansible.netcommon#362 The integration tests in this PR depend on #631 for the VPC configuration. Reviewed-by: Mark Chappell <None> Reviewed-by: Sebastien Rosset <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> (cherry picked from commit c06d77c)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
[PR #634/c06d77c9 backport][stable-3] Improve doc to show support for IPv6 CIDR block This is a backport of PR #634 as merged into main (c06d77c). SUMMARY Improve doc to show IPv6 CIDR blocks are supported. Add example with IPv6 CIDR block. Add missing attribute to return values. Remove duplicate assertions in integration tests. Add tests for IPv6 subnets in integration tests. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_route_table ADDITIONAL INFORMATION While testing IPv6 in this module, I discovered the ipsubnet filter does not work if the prefix length has a fairly high value such as /120. I was running an integration test with a /120 subnet in this PR, but the ipsubnet call never returns and uses 100% CPU. I changed the value to a /64 subnet so this PR can pass. The ipsubnet issue needs to be fixed in ansible.netcommon and the netaddr package. I've created a unit test to reproduce the problem: ansible-collections/ansible.netcommon#362 The integration tests in this PR depend on #631 for the VPC configuration.
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Mar 31, 2022
) (ansible-collections#751) [PR ansible-collections#634/c06d77c9 backport][stable-3] Improve doc to show support for IPv6 CIDR block This is a backport of PR ansible-collections#634 as merged into main (c06d77c). SUMMARY Improve doc to show IPv6 CIDR blocks are supported. Add example with IPv6 CIDR block. Add missing attribute to return values. Remove duplicate assertions in integration tests. Add tests for IPv6 subnets in integration tests. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_route_table ADDITIONAL INFORMATION While testing IPv6 in this module, I discovered the ipsubnet filter does not work if the prefix length has a fairly high value such as /120. I was running an integration test with a /120 subnet in this PR, but the ipsubnet call never returns and uses 100% CPU. I changed the value to a /64 subnet so this PR can pass. The ipsubnet issue needs to be fixed in ansible.netcommon and the netaddr package. I've created a unit test to reproduce the problem: ansible-collections/ansible.netcommon#362 The integration tests in this PR depend on ansible-collections#631 for the VPC configuration.
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…new-tiny_prefix-variable_5260 tests: use the new tiny_prefix variable SUMMARY The new tiny_prefix variable has recently been introduced. It's a 12 characters long string that is reused for the whole job. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests Reviewed-by: Dmytro Vorotyntsev <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ec2_vpc_route_table
ADDITIONAL INFORMATION
ipsubnetfilter does not work if the prefix length has a fairly high value such as/120.ipsubnetcall never returns and uses 100% CPU. I changed the value to a /64 subnet so this PR can pass.ipsubnetissue needs to be fixed in ansible.netcommon and the netaddr package. I've created a unit test to reproduce the problem: Add unit tests for ipsubnet filter and IPv6 ansible.netcommon#362