Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_eni - Increase timeout when waiting for ENIs to detach #501

Merged
merged 3 commits into from
Sep 14, 2021
Merged

ec2_eni - Increase timeout when waiting for ENIs to detach #501

merged 3 commits into from
Sep 14, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 14, 2021

SUMMARY

Increase timeout when waiting for ENIs to detach

https://796bc2ffb2f08daedb4f-dfd1c589d70cb07166ffb8939d1c9bb5.ssl.cf2.rackcdn.com/500/50b47988590728b63925dd979fc5a83a15e40a06/gate/ansible-test-cloud-integration-aws-py36_0/4c3a4d5/job-output.txt

Logs show that the ENI was in the 'detaching' state, implying that our default 40*5 second retries were insufficient

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_eni

ADDITIONAL INFORMATION

Logs show that the ENI had entered a 'detaching' state:

2021-09-14 11:44:06.593046 | fedora-34 |         {
2021-09-14 11:44:06.593054 | fedora-34 |             "attachment": {
2021-09-14 11:44:06.593061 | fedora-34 |                 "attach_time": "2021-09-14T11:40:16+00:00",
2021-09-14 11:44:06.593069 | fedora-34 |                 "attachment_id": "eni-attach-09bb047d2f0f5f293",
2021-09-14 11:44:06.593100 | fedora-34 |                 "delete_on_termination": false,
2021-09-14 11:44:06.593110 | fedora-34 |                 "device_index": 1,
2021-09-14 11:44:06.593118 | fedora-34 |                 "instance_id": "i-0db09d037e72f7e33",
2021-09-14 11:44:06.593127 | fedora-34 |                 "instance_owner_id": "966509639900",
2021-09-14 11:44:06.593135 | fedora-34 |                 "network_card_index": 0,
2021-09-14 11:44:06.593143 | fedora-34 |                 "status": "detaching"
2021-09-14 11:44:06.593151 | fedora-34 |             },
2021-09-14 11:44:06.593160 | fedora-34 |             "availability_zone": "us-east-1a",
2021-09-14 11:44:06.593168 | fedora-34 |             "description": "",
2021-09-14 11:44:06.593176 | fedora-34 |             "groups": [
2021-09-14 11:44:06.593184 | fedora-34 |                 {
2021-09-14 11:44:06.593193 | fedora-34 |                     "group_id": "sg-0e140a452ed923a71",
2021-09-14 11:44:06.593201 | fedora-34 |                     "group_name": "default"
2021-09-14 11:44:06.593209 | fedora-34 |                 }
2021-09-14 11:44:06.593217 | fedora-34 |             ],
2021-09-14 11:44:06.593226 | fedora-34 |             "id": "eni-0a4e0246ce3fe9245",
2021-09-14 11:44:06.593234 | fedora-34 |             "interface_type": "interface",
2021-09-14 11:44:06.593242 | fedora-34 |             "ipv6_addresses": [],
2021-09-14 11:44:06.593250 | fedora-34 |             "mac_address": "12:fe:a9:4f:34:c7",
2021-09-14 11:44:06.593258 | fedora-34 |             "network_interface_id": "eni-0a4e0246ce3fe9245",
2021-09-14 11:44:06.593266 | fedora-34 |             "owner_id": "966509639900",
2021-09-14 11:44:06.593275 | fedora-34 |             "private_dns_name": "ip-10-254-241-132.ec2.internal",
2021-09-14 11:44:06.593283 | fedora-34 |             "private_ip_address": "10.254.241.132",
2021-09-14 11:44:06.593291 | fedora-34 |             "private_ip_addresses": [
2021-09-14 11:44:06.593306 | fedora-34 |                 {
2021-09-14 11:44:06.593315 | fedora-34 |                     "primary": true,
2021-09-14 11:44:06.593337 | fedora-34 |                     "private_dns_name": "ip-10-254-241-132.ec2.internal",
2021-09-14 11:44:06.593345 | fedora-34 |                     "private_ip_address": "10.254.241.132"
2021-09-14 11:44:06.593353 | fedora-34 |                 }
2021-09-14 11:44:06.593361 | fedora-34 |             ],
2021-09-14 11:44:06.593370 | fedora-34 |             "requester_id": "AROAIUOWG2JZBBCEMK7M2:dev=remote=zuul-cloud",
2021-09-14 11:44:06.593378 | fedora-34 |             "requester_managed": false,
2021-09-14 11:44:06.593399 | fedora-34 |             "source_dest_check": true,
2021-09-14 11:44:06.593407 | fedora-34 |             "status": "in-use",
2021-09-14 11:44:06.593414 | fedora-34 |             "subnet_id": "subnet-09d5010acb57dfa83",
2021-09-14 11:44:06.593422 | fedora-34 |             "tag_set": {},
2021-09-14 11:44:06.593429 | fedora-34 |             "tags": {},
2021-09-14 11:44:06.593437 | fedora-34 |             "vpc_id": "vpc-0b9f195f029ca4f69"
2021-09-14 11:44:06.593458 | fedora-34 |         },

Amazon are sometimes just 'slow', if our tests show a 30% failure rate, then better to wait longer, this is probably hitting users.

@ansibullbot
Copy link

cc @healem @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) python3 labels Sep 14, 2021
@ansibullbot ansibullbot added integration tests/integration tests tests and removed owner_pr PR created by owner/maintainer labels Sep 14, 2021
@tremble tremble added the gate label Sep 14, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 894b284 into ansible-collections:main Sep 14, 2021
@tremble tremble deleted the tests/ec2_eni/available_timeout branch November 26, 2021 12:42
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
7cdf980 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
c1cde15 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
c20b102 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
9922f7e 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
50c20a0 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
8012a68 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
0d1c354 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
9cdf8d1 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
2e6ad1e 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 11, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
15b0624 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 16, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
5550655 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
f34f1c0 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
@tremble @alinabuzachis
ec2_vpc_peer - idempotency + integration tests (ansible-collections#501)
2d8200e 
* Add minimal integration tests for ec2_vpc_peer

* Add Retries to VPC Peering

* Fix idempotency when deleting connections

* Fix idempotency when after rejecting peering connections

* Test for updating tags

* Add first round of assertions (changed/successful)

* Add docs about ec2_vpc_peering_info return values

* Make sure Peering IDs are consistent

* docs update

* Initial tests for ec2_vpc_peering_info results

* Use ansible_dict_to_boto3_filter_list

* Add support for waiting on state changes

* Assert shape of results when searching based on status code

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c20b102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr jillr approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) python3 tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @jillr