Enable unit tests and make fixes for collection migration #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Bomb out early if someone tries to set tags without the necessary botocore version
* Simplify some error handling by using fail_json_aws
* Use BotoCoreError rather than the sub-errors
We still bomb out, but fail_json_aws is more graceful and user friendly
than an uncaught Boto3 error.
* use is_boto3_error_code to limit what we catch rather than catching and re-raising.
* Cleanup get_account_info
- use module.client to avoid the mass of extra args
- use is_boto3_error_code('AccessDenied') to be a little cleaner
- fix text search (re.search(, mystring) rather than mystring.search())
* Use module.client helpers
* Delete dead code path - we test for having *both* vpc_subnet_ids and vpc_security_group_ids when we parse the arguments
* Enable basic AWS Retries
* Tweak integration test to allow for common 'missing region' error message
* Rename lambda tests from 'aws_lambda' to 'lambda' (matching the module name)
* Use omit rather than 'null' in the tests - ansible/ansible#69190
* Ignore duplicate-except warnings (it's caused by the way is_boto3_error works)
* change expected error messages now we're using an AnsibleAWSModule feature
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d4e4d3e
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tions#5) * Bomb out early if someone tries to set tags without the necessary botocore version * Simplify some error handling by using fail_json_aws * Use BotoCoreError rather than the sub-errors We still bomb out, but fail_json_aws is more graceful and user friendly than an uncaught Boto3 error. * use is_boto3_error_code to limit what we catch rather than catching and re-raising. * Cleanup get_account_info - use module.client to avoid the mass of extra args - use is_boto3_error_code('AccessDenied') to be a little cleaner - fix text search (re.search(, mystring) rather than mystring.search()) * Use module.client helpers * Delete dead code path - we test for having *both* vpc_subnet_ids and vpc_security_group_ids when we parse the arguments * Enable basic AWS Retries * Tweak integration test to allow for common 'missing region' error message * Rename lambda tests from 'aws_lambda' to 'lambda' (matching the module name) * Use omit rather than 'null' in the tests - ansible/ansible#69190 * Ignore duplicate-except warnings (it's caused by the way is_boto3_error works) * change expected error messages now we're using an AnsibleAWSModule feature
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tions#5) * Bomb out early if someone tries to set tags without the necessary botocore version * Simplify some error handling by using fail_json_aws * Use BotoCoreError rather than the sub-errors We still bomb out, but fail_json_aws is more graceful and user friendly than an uncaught Boto3 error. * use is_boto3_error_code to limit what we catch rather than catching and re-raising. * Cleanup get_account_info - use module.client to avoid the mass of extra args - use is_boto3_error_code('AccessDenied') to be a little cleaner - fix text search (re.search(, mystring) rather than mystring.search()) * Use module.client helpers * Delete dead code path - we test for having *both* vpc_subnet_ids and vpc_security_group_ids when we parse the arguments * Enable basic AWS Retries * Tweak integration test to allow for common 'missing region' error message * Rename lambda tests from 'aws_lambda' to 'lambda' (matching the module name) * Use omit rather than 'null' in the tests - ansible/ansible#69190 * Ignore duplicate-except warnings (it's caused by the way is_boto3_error works) * change expected error messages now we're using an AnsibleAWSModule feature
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…tions#5) * Bomb out early if someone tries to set tags without the necessary botocore version * Simplify some error handling by using fail_json_aws * Use BotoCoreError rather than the sub-errors We still bomb out, but fail_json_aws is more graceful and user friendly than an uncaught Boto3 error. * use is_boto3_error_code to limit what we catch rather than catching and re-raising. * Cleanup get_account_info - use module.client to avoid the mass of extra args - use is_boto3_error_code('AccessDenied') to be a little cleaner - fix text search (re.search(, mystring) rather than mystring.search()) * Use module.client helpers * Delete dead code path - we test for having *both* vpc_subnet_ids and vpc_security_group_ids when we parse the arguments * Enable basic AWS Retries * Tweak integration test to allow for common 'missing region' error message * Rename lambda tests from 'aws_lambda' to 'lambda' (matching the module name) * Use omit rather than 'null' in the tests - ansible/ansible#69190 * Ignore duplicate-except warnings (it's caused by the way is_boto3_error works) * change expected error messages now we're using an AnsibleAWSModule feature
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
* Update Lambda unit tests Units did not run on ansible-collections#5, so it was missed that the tests needed to also be refactored. Update test_lambda.py for AnsibleAWSModule connection types, improve style, and add a deletion test.
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ts (#2087) SUMMARY Ensures the modules documentation follows the correct formats ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis
patchback bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…ts (#2087) SUMMARY Ensures the modules documentation follows the correct formats ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis (cherry picked from commit 7a487f5)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…ts (#2087) (#2242) This is a backport of PR #2087 as merged into main (7a487f5). SUMMARY Ensures the modules documentation follows the correct formats ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Enable unit tests and make fixes for collection migration. This had been missed in the original migration.
ISSUE TYPE
COMPONENT NAME
tests/unit/