Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ec2_import_image* modules #2167

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 1, 2024

SUMMARY

Refactor ec2_import_image,ec2_import_image_info modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_import_image ec2_import_image_info

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5d5a29a5b53f4d49b056f6be97c74141

✔️ ansible-galaxy-importer SUCCESS in 8m 15s
✔️ build-ansible-collection SUCCESS in 15m 58s
✔️ ansible-test-splitter SUCCESS in 6m 36s
Skipped 44 jobs

plugins/modules/ec2_import_image.py Outdated Show resolved Hide resolved
plugins/modules/ec2_import_image.py Outdated Show resolved Hide resolved
plugins/modules/ec2_import_image.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor-modules-ec2_import_image-2401071447 branch from 7390fa5 to 7df6ebe Compare July 3, 2024 13:58
@abikouo abikouo requested a review from alinabuzachis July 3, 2024 14:00
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/446584292996424b8f4a690a76676a7b

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 12m 50s
✔️ ansible-test-splitter SUCCESS in 5m 10s
Skipped 44 jobs

Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions but this looks good!

plugins/modules/ec2_import_image_info.py Show resolved Hide resolved
plugins/modules/ec2_import_image.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor-modules-ec2_import_image-2401071447 branch from 7221040 to 915871d Compare July 8, 2024 10:08
@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jul 8, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/99a5954146914422adf64bb91d8749f0

✔️ ansible-galaxy-importer SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 5m 04s
✔️ integration-amazon.aws-1 SUCCESS in 19m 03s
✔️ integration-amazon.aws-2 SUCCESS in 20m 39s
✔️ integration-amazon.aws-3 SUCCESS in 26m 40s
✔️ integration-amazon.aws-4 SUCCESS in 19m 46s
✔️ integration-amazon.aws-5 SUCCESS in 20m 03s
✔️ integration-amazon.aws-6 SUCCESS in 12m 47s
✔️ integration-amazon.aws-7 SUCCESS in 12m 08s
✔️ integration-amazon.aws-8 SUCCESS in 21m 11s
✔️ integration-amazon.aws-9 SUCCESS in 17m 34s
✔️ integration-amazon.aws-10 SUCCESS in 15m 16s
✔️ integration-amazon.aws-11 SUCCESS in 10m 48s
✔️ integration-amazon.aws-12 SUCCESS in 8m 05s
✔️ integration-amazon.aws-13 SUCCESS in 9m 23s
✔️ integration-amazon.aws-14 SUCCESS in 15m 25s
✔️ integration-amazon.aws-15 SUCCESS in 15m 52s
✔️ integration-amazon.aws-16 SUCCESS in 23m 35s
✔️ integration-amazon.aws-17 SUCCESS in 12m 27s
✔️ integration-amazon.aws-18 SUCCESS in 17m 14s
✔️ integration-amazon.aws-19 SUCCESS in 16m 57s
✔️ integration-amazon.aws-20 SUCCESS in 10m 56s
✔️ integration-amazon.aws-21 SUCCESS in 6m 41s
✔️ integration-community.aws-1 SUCCESS in 16m 01s
✔️ integration-community.aws-2 SUCCESS in 5m 29s
✔️ integration-community.aws-3 SUCCESS in 8m 16s
✔️ integration-community.aws-4 SUCCESS in 10m 40s
✔️ integration-community.aws-5 SUCCESS in 6m 32s
✔️ integration-community.aws-6 SUCCESS in 7m 08s
✔️ integration-community.aws-7 SUCCESS in 6m 46s
Skipped 16 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ed0bdce into ansible-collections:main Jul 8, 2024
34 of 37 checks passed
GomathiselviS added a commit that referenced this pull request Oct 17, 2024
SUMMARY
This PR refactors ec2_placement_group*.
Depends-On: #2322
Refer: https://issues.redhat.com/browse/ACA-1886

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@290e89a
GomathiselviS added a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 17, 2024
…s#2167)

SUMMARY
This PR refactors ec2_placement_group*.
Depends-On: ansible-collections#2322
Refer: https://issues.redhat.com/browse/ACA-1886

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@290e89a
GomathiselviS added a commit that referenced this pull request Oct 17, 2024
SUMMARY
This PR refactors ec2_placement_group*.
Depends-On: #2322
Refer: https://issues.redhat.com/browse/ACA-1886

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@290e89a
GomathiselviS added a commit to GomathiselviS/amazon.aws that referenced this pull request Oct 24, 2024
…s#2167)

SUMMARY
This PR refactors ec2_placement_group*.
Depends-On: ansible-collections#2322
Refer: https://issues.redhat.com/browse/ACA-1886

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@290e89a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants