-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3_bucket transfer accleration #2046
s3_bucket transfer accleration #2046
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 38s |
Integation test failed on "AccessDenied", I have verified the integration test with my own AWS account with S3 admin user, so I have no idea what permissions are missing or how to change them for the CI to pass. |
ping |
@abraverm Thank you for taking time to work on this feature idea. Can you please open a pull request and add the missing permission |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 04s |
I have updated the PR to match the recent changes but CI is still blocked by ansible/aws-ci-admin#5 |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 39s |
recheck |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 12s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! See a few minor comments inline.
tests/integration/targets/s3_bucket/roles/s3_bucket/tasks/accelerate.yml
Show resolved
Hide resolved
@hakbailey thank you for the review, I have addressed your comments in my last commit |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 6m 13s |
I have no clue why the CI failed, the integration tests passed locally |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 9m 02s |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 46s |
recheck |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 30s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more minor comments. This will also need to be rebased onto main to fix the conflicts. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abraverm Thank you for working on this feature idea. Can you also please add a changelog fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment) fro this change?
9883c1b
to
1c9c23b
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 34s |
Signed-off-by: Alina Buzachis <[email protected]>
1c9c23b
to
2a0039c
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 18s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 45s |
3a6e448
into
ansible-collections:main
Backport to stable-8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 3a6e448 on top of patchback/backports/stable-8/3a6e448a93a24c474d281aa49492a3903b662ef7/pr-2046 Backporting merged PR #2046 into main
🤖 @patchback |
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 3a6e448)
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 3a6e448)
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 3a6e448)
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 3a6e448)
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 3a6e448)
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 3a6e448)
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 3a6e448)
Thank you for merging the PR and I'm sorry for the delay on my part to respond. |
Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey [email protected] Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves [email protected] (cherry picked from commit 3a6e448) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]>
Add support for S3 Bucket Transfer Acceleration:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html