[PR #943/8f83de52 backport][stable-3] ec2_metadata_facts - Fix read failure in ansible 2.13+ #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ec2_metadata_facts - Fix read failure in ansible 2.13+ SUMMARY Ansible 2.13+ changes the return conventions of fetch_url when an error occurs. Add a guard to prevent calling read which will be None. Fixes #942 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION Reviewed-by: Vinay Dandekar <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 8f83de5)
tremble
approved these changes
Sep 19, 2022
ansibullbot
added
bug
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/8f83de526c3d3e4939ad69a4a68a7f4e6534ce40/pr-943
branch
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ddd30cf
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ddd30cf
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ddd30cf
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ddd30cf
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ddd30cf
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ddd30cf
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…#1034) rds_instance - add valid choices for engine type SUMMARY Add valid choices for engine and update integration tests with new error msg ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #943 as merged into main (8f83de5).
SUMMARY
Ansible 2.13+ changes the return conventions of fetch_url when an error occurs. Add a guard to prevent calling
readwhich will be None.Fixes #942
ISSUE TYPE
COMPONENT NAME
ec2_metadata_facts
ADDITIONAL INFORMATION