Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop false string in URLs being detected as a truthy value #37

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Stop false string in URLs being detected as a truthy value #37

merged 1 commit into from
Mar 17, 2023

Conversation

rbibby
Copy link
Contributor

@rbibby rbibby commented Mar 17, 2023 •
edited
Loading

This fixes a bug where false in the URL is detected as true because it's not an empty string and so searching for GET /v1/domains?auto_renew=false would always return domains with auto renew on.

@rbibby rbibby requested a review from Gman98ish March 17, 2023 08:50
@Gman98ish Gman98ish merged commit 3adfefa into master Mar 17, 2023
@rbibby rbibby deleted the support-false-in-urls branch March 17, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gman98ish Gman98ish Awaiting requested review from Gman98ish

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbibby @Gman98ish